Bug 242694 - www/py-httmock: Switch to USE_GITHUB, Remove BROKEN
Summary: www/py-httmock: Switch to USE_GITHUB, Remove BROKEN
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Kubilay Kocak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-17 23:15 UTC by Derek Schrock
Modified: 2019-12-20 10:37 UTC (History)
0 users

See Also:
koobs: merge-quarterly+


Attachments
fix unfetchable tests.py (1.46 KB, patch)
2019-12-17 23:15 UTC, Derek Schrock
dereks: maintainer-approval+
Details | Diff
convert to USE_GITHUB (2.33 KB, patch)
2019-12-18 01:53 UTC, Derek Schrock
dereks: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Derek Schrock 2019-12-17 23:15:28 UTC
Created attachment 210018 [details]
fix unfetchable tests.py

tests.py was unfetchable due to size/checksum mismatch.

portlint: ok. looks fine.
testport: ok. 12amd64
unittest: ok. Ran 30 tests in 0.049s
Comment 1 Automation User 2019-12-17 23:43:31 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/103874739
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2019-12-18 01:31:45 UTC
Already looking at this (reported by skered via IRC)
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2019-12-18 01:40:40 UTC
While we prefer CHEESESHOP when the sources are distributed there, the more robust method is to use the repository for the complete sources, rather than a combination of CHEESESHOP+repository for particular files, while reporting upstream issues or creating PR's to add the requisites files to the PyPI sdist in the meantime.

I've done that in https://github.com/patrys/httmock/pull/59
Comment 4 Derek Schrock 2019-12-18 01:53:54 UTC
Created attachment 210020 [details]
convert to USE_GITHUB

Convert to USE_GITHUB
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2019-12-18 02:08:37 UTC
(In reply to Derek Schrock from comment #4)

Thanks Derek, I should have mentioned I have all the changes locally in my WIP to avoid duplicating the work, apologies, but thank you for providing a patch in such short order
Comment 6 commit-hook freebsd_committer freebsd_triage 2019-12-18 02:33:28 UTC
A commit references this bug:

Author: koobs
Date: Wed Dec 18 02:32:49 UTC 2019
New revision: 520357
URL: https://svnweb.freebsd.org/changeset/ports/520357

Log:
  www/py-httmock: Switch to USE_GITHUB, Remove BROKEN

  While we prefer using CHEESESHOP when souces are provided there, in the
  event it's missing valuable files such as tests, test data, LICENCE, it
  is preferable and more robust to use an alternative source entirely, than a
  combination of CHEESESHOP (or anything else) combined with another source
  for specific files, which can cause issues [1]

  This change switches to USE_GITHUB and removes unecessary and associated
  Makefile entries accordingly.

  [1] ports r516897

  See Also:

    https://github.com/patrys/httmock/pull/59

  PR:		242694
  Submitted by:	Derek Schrock <dereks lifeofadishwasher com>
  MFH:		2019Q4 (blanket: fetch/build fix)
  MFH-With:	r516897

Changes:
  head/www/py-httmock/Makefile
  head/www/py-httmock/distinfo
Comment 7 commit-hook freebsd_committer freebsd_triage 2019-12-20 10:36:36 UTC
A commit references this bug:

Author: koobs
Date: Fri Dec 20 10:35:44 UTC 2019
New revision: 520498
URL: https://svnweb.freebsd.org/changeset/ports/520498

Log:
  MFH: r520357 www/py-httmock: Switch to USE_GITHUB, Remove BROKEN

  While we prefer using CHEESESHOP when souces are provided there, in the
  event it's missing valuable files such as tests, test data, LICENCE, it
  is preferable and more robust to use an alternative source entirely, than a
  combination of CHEESESHOP (or anything else) combined with another source
  for specific files, which can cause issues [1]

  This change switches to USE_GITHUB and removes unecessary and associated
  Makefile entries accordingly.

  [1] ports r516897

  See Also:

    https://github.com/patrys/httmock/pull/59

  PR:		242694
  Submitted by:	Derek Schrock <dereks lifeofadishwasher com>

  Approved by:	ports-secteam (blanket: fetch/build fix)

Changes:
_U  branches/2019Q4/
  branches/2019Q4/www/py-httmock/Makefile
  branches/2019Q4/www/py-httmock/distinfo
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2019-12-20 10:37:34 UTC
Committed, with changes, and merged.

Thank you Derek