Bug 242723 - sysutils/burp: missing runtime dependency on shells/bash
Summary: sysutils/burp: missing runtime dependency on shells/bash
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Tobias C. Berner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-19 12:18 UTC by Tassilo Philipp
Modified: 2019-12-22 20:30 UTC (History)
2 users (show)

See Also:

Attachments
patch: add runtime dependency on shells/bash (409 bytes, patch)
2019-12-19 12:18 UTC, Tassilo Philipp 		no flags Details | Diff
burp - with bash dependency (1.23 KB, patch)
2019-12-19 12:47 UTC, Lorenzo Salvadore 		salvadore: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tassilo Philipp 2019-12-19 12:18:45 UTC 
Created attachment 210057 [details]
patch: add runtime dependency on shells/bash

Burp ships with some scripts that need bash, but there is no runtime dependency set for it. I checked whether those scripts are bourne shell compatible and just use a bash shebang, but they indeed use bashisms, although not exhaustively.

I considered patching the scripts to avoid that dependency, but this would put the burden on keeping that updated on the port's maintainer, which isn't the point. So find attached a patch that simply adds the runtime dependency.

Thanks!
Comment 1 Lorenzo Salvadore freebsd_committer freebsd_triage 2019-12-19 12:47:20 UTC 
Created attachment 210058 [details]
burp - with bash dependency

Thanks for your patch!

I just added the necessary PORTREVISION bumps for burp and burp-devel (slave port of burp).
Comment 2 Tassilo Philipp 2019-12-19 14:48:17 UTC 
Ah, sorry, I missed that...
Thanks for the quick feedback!
Comment 3 Tobias C. Berner freebsd_committer freebsd_triage 2019-12-22 20:30:05 UTC 
Committed. Thanks.
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-12-22 20:30:10 UTC 
A commit references this bug:

Author: tcberner
Date: Sun Dec 22 20:29:53 UTC 2019
New revision: 520662
URL: https://svnweb.freebsd.org/changeset/ports/520662

Log:
  sysutils/burp: missing runtime dependency on shells/bash

  Burp ships with some scripts that need bash.

  PR:		242723
  Submitted by:	Tassilo Philipp <tphilipp@potion-studios.com>
  Approved by:	 Lorenzo Salvadore <phascolarctos@protonmail.ch> (maintainer)

Changes:
  head/sysutils/burp/Makefile
  head/sysutils/burp-devel/Makefile