Bug 242756 - [NEW PORT] devel/py-pytest-pep8: Pytest plugin for efficiently checking PEP8 compliance
Summary: [NEW PORT] devel/py-pytest-pep8: Pytest plugin for efficiently checking PEP8 ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kubilay Kocak
URL:
Keywords: feature
Depends on:
Blocks: 242617 242786
  Show dependency tree / graph
 
Reported: 2019-12-21 03:39 UTC by Goran Mekić
Modified: 2020-01-11 13:49 UTC (History)
1 user (show)

See Also:

Attachments
py-pytest-pep8.diff (2.27 KB, patch)
2019-12-21 03:39 UTC, Goran Mekić 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Goran Mekić 2019-12-21 03:39:46 UTC 
Created attachment 210093 [details]
py-pytest-pep8.diff

QA:

  * portlint: OK (looks fine.)
  * testport: OK (poudriere: 12.0, amd64 tested)
  * maketest: OK (6 passed, 4 deselected)
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2020-01-11 12:42:38 UTC 
Review items:

1) USES=python:<version-spec> is incorrect. 3.5+ incorrectly limits version support to >= 3.5 ...

Upstream declares support for 2.6,2.7,3.3,3.4. 

USES=python:<version-spec> should match this as closely as possible without being incorrect, modulo any syntax limitations in <version-spec> (doesn't support !=, etc). 

USES=python is the most correct in this case.

However, if a package doesn't declare support for certain versions, but they are allowed by <version-spec>, port maintainer should QA (test suite) extensively with those undeclared versions to ensure they work, otherwise limit the versions accordingly. In this case, this means explicit QA/test suite testing for 3.5+

2) package dependencies declare versions [1], *_DEPENDS should match these as closely as possible

[1]  install_requires=['pytest-cache', 'pytest>=2.4.2', 'pep8>=1.3', ],
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2020-01-11 13:06:36 UTC 
Note: I've already fixed comment 1 issues locally, no need to update patch
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2020-01-11 13:29:10 UTC 
Python 3.5: 6 passed, 4 deselected in 1.43 seconds 
Python 3.6: 6 passed, 4 deselected in 1.55 seconds
Python 3.7: 6 passed, 4 deselected in 0.88 seconds
Python 3.8: 6 passed, 4 deselected in 1.54 seconds
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2020-01-11 13:32:07 UTC 
Python 2.7: 6 passed, 4 deselected in 1.55 seconds
Comment 5 commit-hook freebsd_committer freebsd_triage 2020-01-11 13:45:58 UTC 
A commit references this bug:

Author: koobs
Date: Sat Jan 11 13:45:38 UTC 2020
New revision: 522685
URL: https://svnweb.freebsd.org/changeset/ports/522685

Log:
  [NEW] devel/py-pytest-pep8: Pytest plugin to check PEP8 requirements

  This plugin allows to configure on a per-project and per-file basis which
  errors or warnings to care about.

  WWW: https://bitbucket.org/pytest-dev/pytest-pep8

  PR:		242756
  Submitted by:	Goran Meki? <meka@tilda.center>

Changes:
  head/devel/Makefile
  head/devel/py-pytest-pep8/
  head/devel/py-pytest-pep8/Makefile
  head/devel/py-pytest-pep8/distinfo
  head/devel/py-pytest-pep8/pkg-descr
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2020-01-11 13:49:01 UTC 
Committed with changes:

  - Those listed in comment 1
  - Tweak COMMENT (match setup.py:description)

Thank you Goran!