Bug 242806 - [NEW PORT] devel/py-pytest-factoryboy: Factory approach to testing with the dependency injection
Summary: [NEW PORT] devel/py-pytest-factoryboy: Factory approach to testing with the d...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ben Woods
URL:
Keywords: patch, patch-ready
Depends on: 242805
Blocks: 242817
  Show dependency treegraph
 
Reported: 2019-12-22 16:29 UTC by Goran Mekić
Modified: 2019-12-24 08:28 UTC (History)
2 users (show)

See Also:


Attachments
py-pytest-factoryboy.diff (2.37 KB, patch)
2019-12-22 16:29 UTC, Goran Mekić
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Goran Mekić 2019-12-22 16:29:03 UTC
Created attachment 210145 [details]
py-pytest-factoryboy.diff

QA:

  * portlint: OK (looks fine.)
  * testport: OK (poudriere: 12.0, amd64 tested)
  * maketest: OK (20 passed, 2 skipped tests)
Comment 1 Ben Woods freebsd_committer 2019-12-24 08:15:43 UTC
Note that this is not required if using GitHub (I will remove it):
MASTER_SITES=	CHEESESHOP
Comment 2 Ben Woods freebsd_committer 2019-12-24 08:18:14 UTC
This is not required, as it is the default (I will remove it):
GH_TAGNAME=	${PORTVERSION}
Comment 3 Ben Woods freebsd_committer 2019-12-24 08:22:15 UTC
I will rename this dependency to match the new package name in the ports tree: 
-		${PYTHON_PKGNAMEPREFIX}factory_boy>=0:devel/py-factory-boy@${PY_FLAVOR} \
+		${PYTHON_PKGNAMEPREFIX}factory-boy>=0:devel/py-factory-boy@${PY_FLAVOR} \
Comment 4 Ben Woods freebsd_committer 2019-12-24 08:25:39 UTC
The lines below are required to fix "make test" (I will add them):
TEST_DEPENDS=   ${PYTHON_PKGNAMEPREFIX}dateutil>=0:devel/py-dateutil@${PY_FLAVOR} \
                ${PYTHON_PKGNAMEPREFIX}text-unidecode>=0:converters/py-text-unidecode@${PY_FLAVOR}
Comment 5 commit-hook freebsd_committer 2019-12-24 08:27:36 UTC
A commit references this bug:

Author: woodsb02
Date: Tue Dec 24 08:27:28 UTC 2019
New revision: 520787
URL: https://svnweb.freebsd.org/changeset/ports/520787

Log:
  Add new port devel/py-pytest-factoryboy

  Pytest-factoryboy makes it easy to combine factory approach to the test setup
  with the dependency injection, heart of the pytest fixtures.

  WWW: https://github.com/pytest-dev/pytest-factoryboy

  PR:		242806
  Submitted by:	Goran Meki? <meka@tilda.center>

Changes:
  head/devel/Makefile
  head/devel/py-pytest-factoryboy/
  head/devel/py-pytest-factoryboy/Makefile
  head/devel/py-pytest-factoryboy/distinfo
  head/devel/py-pytest-factoryboy/pkg-descr
Comment 6 Ben Woods freebsd_committer 2019-12-24 08:28:26 UTC
Committed - thanks!