Bug 242816 - www/rubygem-rails60 invalid run dependency to rubygem-puma
Summary: www/rubygem-rails60 invalid run dependency to rubygem-puma
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Sunpoet Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-22 21:45 UTC by Matthias Fechner
Modified: 2020-04-18 07:23 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments
Remove puma dep from rails (690 bytes, patch)
2019-12-22 21:45 UTC, Matthias Fechner
no flags Details | Diff
Remove puma dep from rails (792 bytes, patch)
2020-04-18 07:16 UTC, Matthias Fechner
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Fechner freebsd_committer 2019-12-22 21:45:17 UTC
Created attachment 210161 [details]
Remove puma dep from rails

The current version has rubygem-puma as depedency.
Regarding this page, there is now run-time depedency for puma:
https://rubygems.org/gems/rails/versions/5.2.4

The new gitlab 12.6.0 version uses:
https://rubygems.org/gems/gitlab-puma

Both puma and gitlab-puma are installing a binary with the same name.
Removing puma from rails52 fixes the problem.

What do you think about the attached patch?
Comment 1 Matthias Fechner freebsd_committer 2020-04-18 07:16:27 UTC
Ping.
Comment 2 Matthias Fechner freebsd_committer 2020-04-18 07:16:55 UTC
Created attachment 213527 [details]
Remove puma dep from rails
Comment 3 Matthias Fechner freebsd_committer 2020-04-18 07:23:45 UTC
Gitlab will switch from unicorn to gitlab-puma.
But gitlab-puma will have a collision with puma.

As puma is not a runtime dependency:
https://rubygems.org/gems/rails

I suggest to remove it here to make it possible in the future to switch for gitlab to gitlab-puma.

I understand the convenience it brings, but if a port requires puma, it should have it as a runtime dep.

Could you please remove puma from the dep list?