Bug 242846 - net-p2p/monero-cli: fix build on non-x86
Summary: net-p2p/monero-cli: fix build on non-x86
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Vasil Dimov
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2019-12-23 23:15 UTC by Piotr Kubaj
Modified: 2020-01-07 12:58 UTC (History)
1 user (show)

See Also:
vd: maintainer-feedback+


Attachments
patch (2.19 KB, patch)
2019-12-23 23:15 UTC, Piotr Kubaj
no flags Details | Diff
v2 (408 bytes, patch)
2019-12-23 23:16 UTC, Piotr Kubaj
pkubaj: maintainer-approval? (vd)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2019-12-23 23:15:54 UTC
Created attachment 210186 [details]
patch

Architectures that don't have libunwind available should disable stack trace.

Otherwise, the following linking error is encountered:
FAILED: bin/monero-gen-ssl-cert 
: && /usr/local/bin/g++9  -O2 -pipe  -D_WANT_SEMUN -fstack-protector-strong -Wl,-rpath=/usr/local/lib/gcc9  -Wl,-rpath=/usr/local/lib/gcc9 -pthread -mcpu=970 -fno-strict-aliasing -std=c++11 -D_GNU_SOURCE   -Wall -Wextra -Wpointer-arith -Wundef -Wvla -Wwrite-strings -Wno-error=extra -Wno-error=deprecated-declarations -Wno-unused-parameter -Wno-unused-variable -Wno-error=unused-variable -Wno-error=undef -Wno-error=uninitialized -Wlogical-op -Wno-error=maybe-uninitialized -Wno-error=cpp -Wno-reorder -Wno-missing-field-initializers  -fPIC  -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -Wformat -Wformat-security -fstack-protector -fstack-protector-strong -fstack-clash-protection -fno-strict-aliasing -ftemplate-depth=900 -DNDEBUG -O2  -L/usr/local/lib  -fstack-protector-strong -Wl,-rpath=/usr/local/lib/gcc9 -L/usr/local/lib/gcc9  -pie -Wl,-z,relro -Wl,-z,now -Wl,-z,noexecstack src/gen_ssl_cert/CMakeFiles/gen_ssl_cert.dir/gen_ssl_cert.cpp.o  -o bin/monero-gen-ssl-cert  -Wl,-rpath,/usr/local/lib: -lexecinfo src/common/libcommon.a contrib/epee/src/libepee.a src/libversion.a contrib/epee/src/libepee_readline.a /usr/local/lib/libboost_program_options.so /usr/local/lib/libboost_filesystem.so -pthread -lexecinfo src/crypto/libcncrypto.a contrib/epee/src/libepee.a external/randomx/librandomx.a /usr/local/lib/libsodium.so /usr/local/lib/libunbound.so /usr/local/lib/libboost_date_time.so /usr/local/lib/libboost_system.so /usr/local/lib/libboost_thread.so /usr/local/lib/libboost_regex.so /usr/local/lib/libboost_chrono.so -lssl -lcrypto external/easylogging++/libeasylogging.a -pthread -lexecinfo /usr/local/lib/libreadline.so /usr/local/lib/libboost_filesystem.so -lexecinfo && :
/usr/local/bin/ld: src/common/libcommon.a(stack_trace.cpp.o): in function `tools::log_stack_trace(char const*)':
stack_trace.cpp:(.text+0x71c): undefined reference to `el::base::debug::StackTrace::generateNew()'
/usr/local/bin/ld: stack_trace.cpp:(.text+0x72c): undefined reference to `el::base::debug::operator<<(std::ostream&, el::base::debug::StackTrace const&)'
collect2: error: ld returned 1 exit status
Comment 1 Piotr Kubaj freebsd_committer 2019-12-23 23:16:45 UTC
Created attachment 210187 [details]
v2

Correct patch.
Comment 2 Automation User 2020-01-07 01:39:05 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/107403845
Comment 3 commit-hook freebsd_committer 2020-01-07 11:45:38 UTC
A commit references this bug:

Author: pkubaj
Date: Tue Jan  7 11:45:08 UTC 2020
New revision: 522326
URL: https://svnweb.freebsd.org/changeset/ports/522326

Log:
  net-p2p/monero-cli: fix build on non-x86

  Architectures that don't have libunwind available should disable stack trace.

  Otherwise, the following linking error is encountered:
  /usr/local/bin/ld: src/common/libcommon.a(stack_trace.cpp.o): in function `tools::log_stack_trace(char const*)':
  stack_trace.cpp:(.text+0x71c): undefined reference to `el::base::debug::StackTrace::generateNew()'
  /usr/local/bin/ld: stack_trace.cpp:(.text+0x72c): undefined reference to `el::base::debug::operator<<(std::ostream&, el::base::debug::StackTrace const&)'
  collect2: error: ld returned 1 exit status

  PR:		242846
  Approved by:	vd (maintainer timeout)
  MFH:		2020Q1 (fix build blanket)

Changes:
  head/net-p2p/monero-cli/Makefile
Comment 4 commit-hook freebsd_committer 2020-01-07 11:46:39 UTC
A commit references this bug:

Author: pkubaj
Date: Tue Jan  7 11:46:24 UTC 2020
New revision: 522327
URL: https://svnweb.freebsd.org/changeset/ports/522327

Log:
  MFH: r522326

  net-p2p/monero-cli: fix build on non-x86

  Architectures that don't have libunwind available should disable stack trace.

  Otherwise, the following linking error is encountered:
  /usr/local/bin/ld: src/common/libcommon.a(stack_trace.cpp.o): in function `tools::log_stack_trace(char const*)':
  stack_trace.cpp:(.text+0x71c): undefined reference to `el::base::debug::StackTrace::generateNew()'
  /usr/local/bin/ld: stack_trace.cpp:(.text+0x72c): undefined reference to `el::base::debug::operator<<(std::ostream&, el::base::debug::StackTrace const&)'
  collect2: error: ld returned 1 exit status

  PR:		242846
  Approved by:	vd (maintainer timeout)
  Approved by:	portmgr (fix build blanket)

Changes:
_U  branches/2020Q1/
  branches/2020Q1/net-p2p/monero-cli/Makefile
Comment 5 Vasil Dimov freebsd_committer 2020-01-07 12:58:18 UTC
Thanks, Piotr! This somehow slipped through the cracks (I forgot to handle it).