Bug 242879 - [patch] sysutils/xfce4-kbdleds-plugin make fetchable
Summary: [patch] sysutils/xfce4-kbdleds-plugin make fetchable
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-xfce (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-25 11:59 UTC by Zane C. Bowers-Hadley
Modified: 2019-12-26 19:45 UTC (History)
3 users (show)

See Also:
madpilot: maintainer-feedback+

Attachments
svn diff (1.88 KB, patch)
2019-12-25 11:59 UTC, Zane C. Bowers-Hadley 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zane C. Bowers-Hadley 2019-12-25 11:59:57 UTC 
Created attachment 210221 [details]
svn diff

Not finding the original tar.bz2 archive.

Looking the git.xfce.org, I found it there as .tar.gz file. Although this patch is not check via the site list. Went and added a additional line there that makes this fetchable as a .tar.gz file.
Comment 1 Olivier Duchateau 2019-12-25 14:20:38 UTC 
This panel is very outdated, no update for 8 years.
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2019-12-25 21:13:21 UTC 
Hi,

The distfile you propose looks quite different from the original one, and while it comes from first hand source it needs some checking too not introduce differences.

Apart from this, as Olivier noted, this plugin is quite old and looks unmaintained. While this is not a big problem right now, it will not work with XFCE 4.15 (development version) and XFCE 4.16 when that will be released without updates. This is due to XFCE 4.15 migrating to GTK3 only.

So while it can stay in the tree for now, it will most probably have to be removed when XFCE will be updated to 4.16 in the future.

I'll have a look and see if this new distfile is ok.
Comment 3 Olivier Duchateau 2019-12-25 21:46:11 UTC 
When you add Git snapshot in MASTER_SITES, you need to adjust dependencies too, especially here:

> BUILD_DEPENDS=  xdt-autogen:devel/xfce4-dev-tools
> ...
> USE= autoreconf

Because configure script has not yet generated.
Comment 4 Guido Falsi freebsd_committer freebsd_triage 2019-12-25 23:20:57 UTC 
(In reply to Olivier Duchateau from comment #3)

I'm testing his patch (with slight modifications, like changing master sites only inside the port) and it looks like the tarball actually includes a working configure script, so no need to add dependencies or regenerate it.

BTW I noticed some linux distributions using this same distfile (same sha256 sum), this lessens my worries about unwanted differences.
Comment 5 commit-hook freebsd_committer freebsd_triage 2019-12-26 19:43:48 UTC 
A commit references this bug:

Author: madpilot
Date: Thu Dec 26 19:43:22 UTC 2019
New revision: 520947
URL: https://svnweb.freebsd.org/changeset/ports/520947

Log:
  Make xfce4-kbdleds-plugin fetchable again by grabbing distfile from
  upstream git repo directly, remove BROKEN line.

  PR:		242879
  Submitted by:	Zane C. Bowers-Hadley <vvelox@vvelox.net>

Changes:
  head/sysutils/xfce4-kbdleds-plugin/Makefile
  head/sysutils/xfce4-kbdleds-plugin/distinfo
Comment 6 Guido Falsi freebsd_committer freebsd_triage 2019-12-26 19:45:50 UTC 
Committed, but made the MASTER_SITES change local to this port only.

Thanks!