Bug 243022 - www/glassfish: please change the default to jdk8+
Summary: www/glassfish: please change the default to jdk8+
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Johannes M Dieterich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-01 19:03 UTC by Pedro F. Giffuni
Modified: 2020-01-04 20:48 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (jmd)


Attachments
patch: portlint, change java version (673 bytes, patch)
2020-01-01 23:52 UTC, Pedro F. Giffuni
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro F. Giffuni freebsd_committer 2020-01-01 19:03:54 UTC
JAVA_VERSION in the glassfish port is set to 11+ but it should be 8+.

The upstream repository at
https://github.com/eclipse-ee4j/glassfish

explicitly mentions JDK8+ as the prerequisite and the tests also run un jdk8.

While openjdk is fine, on commercial environments there may be some resistance towards jdk11 due to the license change from Oracle.
Comment 1 Pedro F. Giffuni freebsd_committer 2020-01-01 23:52:12 UTC
Created attachment 210379 [details]
patch: portlint, change java version

- portlint: extra space on first line.
- Drop java version: all supported versions should work fine.
- the portsuffix and conflicts seem redundant now.
Comment 2 commit-hook freebsd_committer 2020-01-04 20:48:17 UTC
A commit references this bug:

Author: jmd
Date: Sat Jan  4 20:47:57 UTC 2020
New revision: 522061
URL: https://svnweb.freebsd.org/changeset/ports/522061

Log:
  www/glassfish: downgrade Java requirement to Java8

  While there, pet portlint and update conflicts.

  PR:		243022
  Submitted by:	pfg (with changes)

Changes:
  head/www/glassfish/Makefile