Bug 243058 - net/dpdk: fix build with 13-CURRENT
Summary: net/dpdk: fix build with 13-CURRENT
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-03 14:15 UTC by Bruce Richardson
Modified: 2020-02-12 14:02 UTC (History)
1 user (show)

See Also:


Attachments
Patch fixes for compile on 13-CURRENT (2.94 KB, patch)
2020-01-03 14:15 UTC, Bruce Richardson
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bruce Richardson 2020-01-03 14:15:06 UTC
Created attachment 210418 [details]
Patch fixes for compile on 13-CURRENT

The automated package builds for net/dpdk are failing on 13-CURRENT because of changes to the FreeBSD code in the 13 tree. This update provides minor tweaks to the code to fix compatibility with BSD 13.

Two issues were observed:
* rename of CPU_NAND to CPU_ANDNOT
* change in vm_page_replace parameters and behaviour

Both issues only required small changes to a single file, and both fixes are in the diff attached.

This patches have also been submitted upstream for inclusion in future DPDK releases: http://patches.dpdk.org/project/dpdk/list/?series=7977
Comment 1 Kurt Jaeger freebsd_committer 2020-01-12 16:50:51 UTC
https://people.freebsd.org/~pi/logs/dpdk-on-current-build-error.txt
shows a build error with this patch. Any ideas, why that is the case ?
Comment 2 Bruce Richardson 2020-01-13 13:02:17 UTC
(In reply to Kurt Jaeger from comment #1)

Is that with the latest kernel sources? Checking https://github.com/freebsd/freebsd/blob/master/sys/vm/vm_page.h#L650 or https://svnweb.freebsd.org/base/head/sys/vm/vm_page.h?view=annotate#l650 shows vm_page_replace with 4 rather than 3 parameters, as is adjusted by the patch.
Comment 3 Kurt Jaeger freebsd_committer 2020-01-13 13:06:06 UTC
It's with r354278, so before the change to vm_page_replace().

It will take a bit until I find time to update my testbox to a more recent -CUR.
Comment 4 Bruce Richardson 2020-02-12 14:02:23 UTC
Ping, any update on testing this?
Thanks.