Bug 243077 - www/py-django[22|30]: Unbreak with MySQL, switch to py-mysqlclient
Summary: www/py-django[22|30]: Unbreak with MySQL, switch to py-mysqlclient
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Dima Panov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-04 08:33 UTC by Dima Panov
Modified: 2020-01-11 14:09 UTC (History)
2 users (show)

See Also:
sunpoet: maintainer-feedback+
koobs: merge-quarterly+


Attachments
Switch to py-mysqlclient (1.49 KB, patch)
2020-01-04 08:33 UTC, Dima Panov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dima Panov freebsd_committer 2020-01-04 08:33:20 UTC
Created attachment 210437 [details]
Switch to py-mysqlclient

Currently py-django* ports uses databases/pyMySQLdb which is outdated and don't support python3x

Switch Django22/30 ports to fork of pyMySQLdb, py-mysqlclient, with full py3 support
Comment 1 Sunpoet Po-Chuan Hsieh freebsd_committer 2020-01-04 15:04:33 UTC
LGTM.
According to [1] and [2], mysqlclient is the recommended choice for mysql.
BTW, please set version requirement to >=1.3.13.
Thanks!

[1] https://docs.djangoproject.com/en/2.2/ref/databases/#mysql-notes
[2] https://docs.djangoproject.com/en/3.0/ref/databases/#mysql-notes
Comment 2 commit-hook freebsd_committer 2020-01-04 16:29:44 UTC
A commit references this bug:

Author: fluffy
Date: Sat Jan  4 16:29:09 UTC 2020
New revision: 522041
URL: https://svnweb.freebsd.org/changeset/ports/522041

Log:
  www/py-django[22|30]: Unbreak with MySQL, switch to py-mysqlclient

  According to official docs, mysqlclient >=1.3.13 is the recommended
  choice instead of outdated pyMySQLdb

  PR:		243077
  Submitted by:	fluffy
  Approved by:	sunpoet (maintaner, python@)
  MFH:		2020Q1

Changes:
  head/www/py-django22/Makefile
  head/www/py-django30/Makefile
Comment 3 Dima Panov freebsd_committer 2020-01-04 16:47:17 UTC
Committed!
Comment 4 commit-hook freebsd_committer 2020-01-04 17:17:49 UTC
A commit references this bug:

Author: fluffy
Date: Sat Jan  4 17:17:05 UTC 2020
New revision: 522044
URL: https://svnweb.freebsd.org/changeset/ports/522044

Log:
  MFH: r522041

  www/py-django[22|30]: Unbreak with MySQL, switch to py-mysqlclient

  According to official docs, mysqlclient >=1.3.13 is the recommended
  choice instead of outdated pyMySQLdb

  PR:		243077
  Submitted by:	fluffy
  Approved by:	sunpoet (maintaner, python@)

  Approved by:	ports-secteam (joneum)

Changes:
_U  branches/2020Q1/
  branches/2020Q1/www/py-django22/Makefile
  branches/2020Q1/www/py-django30/Makefile
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2020-01-11 14:09:43 UTC
^Triage:

 - Assign to committer that resolved
 - Track MFH