Bug 243121 - net/mtr: update 0.93 broken: Failure to start mtr-packet: Invalid argument
Summary: net/mtr: update 0.93 broken: Failure to start mtr-packet: Invalid argument
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-06 00:00 UTC by Konstantin Belousov
Modified: 2020-01-07 12:39 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Belousov freebsd_committer 2020-01-06 00:00:53 UTC 
It seems that the update forgot to fill sa_len in the struct sockaddr.

The result is
solo% mtr freefall.freebsd.org                                                ~
Error decoding localhost address
mtr: Failure to start mtr-packet: Invalid argument

The 'error' part comes from mtr-packet, which does the following

 62130 mtr-packet CALL  socket(PF_INET,0x2<SOCK_DGRAM>,IPPROTO_UDP)
 62130 mtr-packet RET   socket 8
 62130 mtr-packet CALL  connect(0x8,0x7fffffffb550,0x4)
 62130 mtr-packet STRU  struct sockaddr { AF_INET, invalid }
 62130 mtr-packet RET   connect -1 errno 22 Invalid argument
 62130 mtr-packet CALL  close(0x8)
Comment 1 commit-hook freebsd_committer 2020-01-06 14:45:56 UTC 
A commit references this bug:

Author: sunpoet
Date: Mon Jan  6 14:45:40 UTC 2020
New revision: 522253
URL: https://svnweb.freebsd.org/changeset/ports/522253

Log:
  Fix "mtr-packet: Invalid argument" runtime error

  - Bump PORTREVISION for package change

  PR:		243121
  Reported by:	kib

Changes:
  head/net/mtr/Makefile
  head/net/mtr/files/patch-packet-probe.c
  head/net/mtr/files/patch-packet-probe_unix.c