Bug 243158 - x11/libICE: add DOCS option
Summary: x11/libICE: add DOCS option
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 (Nobody)
Keywords: buildisok
Depends on:
Reported: 2020-01-07 13:12 UTC by Andrew Romanenko
Modified: 2020-09-17 09:51 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (x11)

libICE.patch (865 bytes, patch)
2020-01-07 13:12 UTC, Andrew Romanenko
no flags Details | Diff
libICE_v0.patch (780 bytes, patch)
2020-01-07 13:40 UTC, Andrew Romanenko
no flags Details | Diff
libICE_v1.patch (758 bytes, patch)
2020-01-07 18:41 UTC, Andrew Romanenko
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Romanenko 2020-01-07 13:12:20 UTC
Created attachment 210500 [details]

Add option for DOCS (disabled by default)
Comment 1 Niclas Zeising freebsd_committer 2020-01-07 13:15:54 UTC
I see little reason for this, considering it's only 2 files that are affected.  However, they should be installed by default (the DOCS option should be enabled), this way the package isn't changed.
Comment 2 Andrew Romanenko 2020-01-07 13:40:09 UTC
Created attachment 210501 [details]

Comment 3 Niclas Zeising freebsd_committer 2020-01-07 14:22:06 UTC
The patch isn't complete, %%PORTDOCS%%%%DOCSDIR%%/ice.xml is still installed into the stage dir even when DOCS is off.

You don't need to set DOCS in OPTIONS_DEFAULT, it's added automatically by the framework.
Comment 4 Andrew Romanenko 2020-01-07 18:41:32 UTC
Created attachment 210510 [details]

OPTIONS_DEFAULT removed, %%PORTDOCS%%%%DOCSDIR%%/ice.xml is not installed if DOCS is off (build via poudriere 12.1/STABLE amd64).

thanks for DOCS is on by default via framework.
Comment 5 Automation User 2020-01-22 00:08:57 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/111247407
Comment 6 Niclas Zeising freebsd_committer 2020-09-17 09:51:20 UTC
This is very little benefit for a lot of complexity.  It is just two files in the package, text files that compresses quite well, but it means that on every update or test I need to test both the case with or without the DOCS option, doubling the number of tests needed.