Bug 243161 - net/remmina-plugin-rdp fails to build when CUPS turned off globaly
Summary: net/remmina-plugin-rdp fails to build when CUPS turned off globaly
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ben Woods
Depends on:
Reported: 2020-01-07 15:05 UTC by Marko Cupać
Modified: 2020-11-24 02:11 UTC (History)
1 user (show)

See Also:
woodsb02: maintainer-feedback+

Makefile patch (343 bytes, patch)
2020-09-08 19:55 UTC, David Marec
woodsb02: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marko Cupać 2020-01-07 15:05:14 UTC

I can't seem to build remmina-plugin-rdp lately, it fails with the following message (I have "OPTIONS_UNSET= CUPS DOCS" in poudriere's make.conf):

-- Finding suggested package Cups.
--   Disable this using "-DWITH_CUPS=OFF".
CMake Error at /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:146 (message):
  Could NOT find Cups (missing: CUPS_LIBRARIES CUPS_INCLUDE_DIR)
Call Stack (most recent call first):
  /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:393 (_FPHSA_FAILURE_MESSAGE)
  /usr/local/share/cmake/Modules/FindCups.cmake:83 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  cmake/FindOptionalPackage.cmake:37 (find_package)
  plugins/rdp/CMakeLists.txt:40 (find_suggested_package)

Best regards,
Comment 1 Marko Cupać 2020-04-16 07:44:00 UTC

any news regarding this issue?

Port is broken for 3 months now for people who disable CUPS globally in make.conf.
Comment 2 David Marec 2020-09-08 19:55:50 UTC
Created attachment 217826 [details]
Makefile patch

Adds a new 'CUPS' option to pass WITH_CUPS  to CMake.
Comment 3 Marko Cupać 2020-09-09 07:43:48 UTC
(In reply to David Marec from comment #2)

With this patch, remmina-plugin-rdp builds fine with CUPS disabled globally in make.conf.

It also installs and works well.
Comment 4 Marko Cupać 2020-10-05 14:45:30 UTC
Any chance to have David's patch commited to ports tree? It works fine for me, without it port won't compile when CUPS is disabled globally in make.conf.
Comment 5 Ben Woods freebsd_committer 2020-11-24 02:10:56 UTC
This was fixed during the commit to flavorize net/remmina:

Thanks for reporting this Marko, and for providing the fix David!