Bug 243163 - [PATCH] graphics/flasm: fix build with gperf 3.1
Summary: [PATCH] graphics/flasm: fix build with gperf 3.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jun Kuriyama
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2020-01-07 17:17 UTC by Dirk Meyer
Modified: 2020-02-01 20:21 UTC (History)
0 users

See Also:
dinoex: maintainer-feedback-


Attachments
suugested patch (2.43 KB, patch)
2020-01-07 17:17 UTC, Dirk Meyer
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Meyer freebsd_committer freebsd_triage 2020-01-07 17:17:26 UTC
Created attachment 210507 [details]
suugested patch

After update to gperf 3.1 the port fails to build.

===>  Building for flasm-1.62
gmake[1]: Entering directory '/data/image/usr/ports/graphics/flasm/work/flasm-1.62'
cc -O2 -pipe  -fstack-protector-strong -fno-strict-aliasing    -c -o util.o util.c
bison --defines --debug assembler.y
gperf --language=ANSI-C -t -T -E -o -k 1,$,2,5 -S8 keywords.gperf > keywords.c
cc -O2 -pipe  -fstack-protector-strong -fno-strict-aliasing    -c -o keywords.o keywords.c
keywords.gperf:76:1: error: conflicting types for 'in_word_set'
in_word_set (register const char *str, register size_t len)
^
keywords.gperf:14:17: note: previous declaration is here
struct keyword *in_word_set(register const char *str, register unsigned int len);
                ^
1 error generated.
gmake[1]: *** [<builtin>: keywords.o] Error 1


In the API the type has changed from "unsigned int" to "size_t"

The attached patch fixes build for me.
Comment 1 Automation User 2020-01-22 00:24:37 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/111248325
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-02-01 20:05:44 UTC
A commit references this bug:

Author: dinoex
Date: Sat Feb  1 20:05:10 UTC 2020
New revision: 524787
URL: https://svnweb.freebsd.org/changeset/ports/524787

Log:
  - fix build with gperf 3.1
  PR:		243163
  Approved by:	(maintainer timeout)

Changes:
  head/graphics/flasm/Makefile
  head/graphics/flasm/files/patch-keywords.gperf
  head/graphics/flasm/files/patch-util.h