Bug 243192 - www/node: 13.3.0 fails to build: undefined identifier in file src/node_crypto.cc
Summary: www/node: 13.3.0 fails to build: undefined identifier in file src/node_crypto.cc
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Bradley T. Hughes
Keywords: needs-qa
Depends on:
Reported: 2020-01-08 15:49 UTC by Kipa Tachak
Modified: 2020-01-28 21:37 UTC (History)
2 users (show)

See Also:
bhughes: maintainer-feedback+

patch file (456 bytes, text/plain)
2020-01-08 15:49 UTC, Kipa Tachak
bhughes: maintainer-approval-

Note You need to log in before you can comment on or make changes to this bug.
Description Kipa Tachak 2020-01-08 15:49:06 UTC
Created attachment 210538 [details]
patch file

Build fails due to due to undefined indentifier in file src/node_crypto.cc line 7102.
Comment 1 Walter Schwarzenfeld freebsd_triage 2020-01-08 17:52:30 UTC
(In reply to Kipa Tachak from comment #0)
Which system, platform and buildtool?

I build node-13.3.0 on 6.1 with poudriere without problems on 12.0.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2020-01-09 04:04:27 UTC
@Kipa Thank you for your report. Could you please provide additional information, including:

- Exact FreeBSD version (uname -a)
- Complete failing build log (as an attachment)
- pkg version -v output (as an attachment)
- /etc/make.conf contents (as an attachment)
Comment 3 Kipa Tachak 2020-01-09 18:31:22 UTC
(In reply to Kubilay Kocak from comment #2)

- Output of uname -a
  >> FreeBSD 12.0-RELEASE-p10

- pkg version
  >> 1.12.0

The build error came up for node as a dependency for firefox. Unfortunately I didn't save the error log. Also I don't have /etc/make.conf. I have included a patch file in my report earlier. The build succeeded on applying the patch. I think it is not a bug, just a error in variable naming.
Comment 4 Kipa Tachak 2020-01-09 18:37:03 UTC
(In reply to Walter Schwarzenfeld from comment #1)
I am using portmaster. The build succeeds on applying the patch.
Comment 5 Bradley T. Hughes freebsd_committer 2020-01-28 21:35:53 UTC
This is a known problem when building Node.js against the OpenSSL version included in 12.0-RELEASE. I highly recommend upgrading to 12.1-RELEASE at least, alternatively you can enable the BUNDLED_SSL option to get it to build.

See https://svnweb.freebsd.org/ports?view=revision&revision=517009
Comment 6 Bradley T. Hughes freebsd_committer 2020-01-28 21:37:37 UTC
Comment on attachment 210538 [details]
patch file

I am not sure that these two functions are interchangeable. As I commented on the bug, I recommend either upgrading to 12.1-RELEASE or enabling BUNDLED_SSL. Changing to using OpenSSL is also an option, I think.