Bug 243205 - sysutils/lsof: Replace lines that '.so' are used with contents of included files in Lsof.8
Summary: sysutils/lsof: Replace lines that '.so' are used with contents of included fi...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Larry Rosenman
Depends on:
Reported: 2020-01-09 04:00 UTC by Yasuhiro Kimura
Modified: 2020-09-01 08:34 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (ler)

Patch file (683 bytes, patch)
2020-01-09 04:00 UTC, Yasuhiro Kimura
no flags Details | Diff
Makefile patch (561 bytes, patch)
2020-04-30 00:59 UTC, Jamie Landeg-Jones
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura freebsd_committer 2020-01-09 04:00:24 UTC
Created attachment 210553 [details]
Patch file

Original Lsof.8 uses '.so' to include other files and it causes lsof(8) is not found by man command. So replace such lines with contents of included files.
Comment 1 Jamie Landeg-Jones 2020-04-30 00:58:11 UTC
Yep, I noticed this.

Larry, if you remember, I posted a fix for this a while back (bug #239686)

Unfortunately, there's a bug in the latest version of mandoc (that now ships with FreeBSD) that means this is no longer working. (I've reported it upstream)

In the meantime, here's a more robust fix.

Unlike the fix from Yasuhiro, this includes the "include" files rather than simply ignoring them.

Cheers, Jamie
Comment 2 Jamie Landeg-Jones 2020-04-30 00:59:00 UTC
Created attachment 213926 [details]
Makefile patch
Comment 3 Jamie Landeg-Jones 2020-04-30 01:00:54 UTC
Ooops, probably a good idea to bump the revision too, as current installs won't be able to see the manpage unless they reinstall.

Comment 4 Jamie Landeg-Jones 2020-04-30 01:06:38 UTC
(In reply to Yasuhiro KIMURA from comment #0)

Apologies, I misread your patch... Must have more coffee!!!

However, I humbly suggest using "soelim(1)" which is specifically written as a generic pre-processor for .so requests.

The line it replaces in my patch was the previous fix, that due to the above mentioned mandoc changes, no longer does anything.
Comment 5 commit-hook freebsd_committer 2020-04-30 01:14:17 UTC
A commit references this bug:

Author: ler
Date: Thu Apr 30 01:13:24 UTC 2020
New revision: 533405
URL: https://svnweb.freebsd.org/changeset/ports/533405

  sysutils/lsof: handle the .so's in the manpage, working around a mandoc bug.

  PR:		243205
  Submitted by:	jamie@catflap.org
  Reported by:	yasu@utahime.org

Comment 6 Larry Rosenman freebsd_committer 2020-04-30 01:15:34 UTC
Committed Jamies's fix.

Comment 7 Jamie Landeg-Jones 2020-09-01 08:34:56 UTC
(In reply to Jamie Landeg-Jones from comment #1)

Just in case anyone comes here from a google search, I've had an update from Ingo Schwarze - the mandoc method is no longer supported (it was a bit of a hacky solution anyway)

The "soelim" fix we are now using is now the recommended method.