Bug 243257 - devel/json-c: 0.13.1 make test fails to compile
Summary: devel/json-c: 0.13.1 make test fails to compile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Sunpoet Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-10 22:37 UTC by daniel.engberg.lists
Modified: 2020-01-11 10:43 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description daniel.engberg.lists 2020-01-10 22:37:08 UTC
On both 12.1-RELEASE-p1 and 13.0-CURRENT #0 r356392 (both AMD64) make test fails.

cc -DHAVE_CONFIG_H -I. -I..  -I.. -I../tests    -O2 -pipe -march=ivybridge  -fstack-protector-strong -fno-strict-aliasing  -Wall -Werror -Wcast-qual -Wno-error=deprecated-declarations -Wextra -Wno-unused-parameter -D_GNU_SOURCE -D_REENTRANT -MT test_parse.o -MD -MP -MF .deps/test_parse.Tpo -c -o test_parse.o test_parse.c
test_parse.c:256:14: error: adding 'int' to a string does not append to the
      string [-Werror,-Wstring-plus-int]
        { "null123" + 4,       4, 3, json_tokener_success, 1 },
          ~~~~~~~~~~^~~
test_parse.c:256:14: note: use array indexing to silence this warning
        { "null123" + 4,       4, 3, json_tokener_success, 1 },
                    ^
          &         [  ]
test_parse.c:258:12: error: adding 'int' to a string does not append to the
      string [-Werror,-Wstring-plus-int]
        { "nullx" + 4,         2, 0, json_tokener_error_parse_unexpected, 1 },
          ~~~~~~~~^~~
test_parse.c:258:12: note: use array indexing to silence this warning
        { "nullx" + 4,         2, 0, json_tokener_error_parse_unexpected, 1 },
                  ^
          &       [  ]
test_parse.c:260:25: error: adding 'int' to a string does not append to the
      string [-Werror,-Wstring-plus-int]
        { "{\"a\":1}{\"b\":2}" + 7,
          ~~~~~~~~~~~~~~~~~~~~~^~~
test_parse.c:260:25: note: use array indexing to silence this warning
        { "{\"a\":1}{\"b\":2}" + 7,
                               ^
          &                    [  ]
3 errors generated.
*** Error code 1

Seems like we can remove gmake dependency as main lib compiles without it. 

Best regards,
Daniel
Comment 1 commit-hook freebsd_committer 2020-01-11 10:43:36 UTC
A commit references this bug:

Author: sunpoet
Date: Sat Jan 11 10:43:32 UTC 2020
New revision: 522673
URL: https://svnweb.freebsd.org/changeset/ports/522673

Log:
  Fix make test

  - Remove USES=gmake

  PR:		243257
  Reported by:	Daniel Engberg <daniel.engberg.lists@pyret.net>

Changes:
  head/devel/json-c/Makefile
  head/devel/json-c/files/
  head/devel/json-c/files/patch-tests-test_parse.c
Comment 2 Sunpoet Po-Chuan Hsieh freebsd_committer 2020-01-11 10:43:59 UTC
Committed. Thanks!