Bug 243279 - databases/mariadb101-server: Fails to build with lz4 and new cmake:
Summary: databases/mariadb101-server: Fails to build with lz4 and new cmake:
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Bernard Spil
Keywords: needs-qa, regression
Depends on:
Reported: 2020-01-11 22:50 UTC by Henrik Hudson
Modified: 2020-02-04 12:32 UTC (History)
2 users (show)

See Also:
koobs: maintainer-feedback? (brnrd)
koobs: merge-quarterly?

mariadb101-server poudriere build log (58.08 KB, text/plain)
2020-01-11 22:53 UTC, Henrik Hudson
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Henrik Hudson 2020-01-11 22:50:54 UTC
cmake was updated on Jan 6th and since then my mariadb101-server poudriere build has been failing. I have the 'LZ4' port option enabled and it seems that the cmake build can't find lz4.

Attached is the poudriere build log.
Comment 1 Henrik Hudson 2020-01-11 22:53:17 UTC
Created attachment 210641 [details]
mariadb101-server poudriere build log
Comment 2 Adriaan de Groot freebsd_committer 2020-01-13 12:33:20 UTC
The important bit is in the configure / cmake output:

-- =====> cpprestsdk package not found
-- Looking for include file lz4.h
-- Looking for include file lz4.h - found
-- Looking for LZ4_compress_limitedOutput in lz4
-- Looking for LZ4_compress_limitedOutput in lz4 - not found
-- Looking for LZ4_compress_default in lz4
-- Looking for LZ4_compress_default in lz4 - not found
CMake Error at cmake/lz4.cmake:31 (MESSAGE):
  Required lz4 library is not found
Call Stack (most recent call first):
  storage/innobase/CMakeLists.txt:28 (MYSQL_CHECK_LZ4)
Comment 3 Bernard Spil freebsd_committer 2020-02-02 17:01:05 UTC
Issue is with paths used by cmake during detection.

Since I'm not a cmake guru, I'm marking the options BROKEN for 10.1 with a hint to update to a newer version (10.[2-4]).

Update of the port coming up for the security fix.
Comment 4 commit-hook freebsd_committer 2020-02-02 17:58:40 UTC
A commit references this bug:

Author: brnrd
Date: Sun Feb  2 17:58:01 UTC 2020
New revision: 524993
URL: https://svnweb.freebsd.org/changeset/ports/524993

  databases/mariadb101-server: Security update to 10.1.44

  PR:		243279
  MFH:		2020Q1
  Security:	a6cf65ad-37d2-11ea-a1c7-b499baebfeaf
  Security:	CVE-2020-2574

Comment 5 Bernard Spil freebsd_committer 2020-02-02 19:57:32 UTC
Marked BROKEN in r524993
and set EXPIRY in r524999
Comment 6 Adriaan de Groot freebsd_committer 2020-02-04 12:22:42 UTC
Later versions do build normally with LZ4 OPTION enabled (as brnrd@ mentions), so it seems the best thing would be to just chase an update.
Comment 7 Bernard Spil freebsd_committer 2020-02-04 12:32:56 UTC
I did check the differences between these versions. The 10.1 cmake script is a completely different implementation.