Bug 243281 - audio/ardour5: fix build on powerpc64
Summary: audio/ardour5: fix build on powerpc64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: powerpc Any
: --- Affects Some People
Assignee: Piotr Kubaj
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2020-01-12 00:17 UTC by Piotr Kubaj
Modified: 2020-01-12 03:01 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (beerml)
koobs: merge-quarterly?


Attachments
patch (1.53 KB, patch)
2020-01-12 00:17 UTC, Piotr Kubaj
koobs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2020-01-12 00:17:36 UTC
Created attachment 210645 [details]
patch

_POSIX_SOURCE causes some errors in errno.h not to be seen (like EAFNOSUPPORT), so remove it.

On ELFv2 lld can't link it, throws errors like:
ld: error: relocation R_PPC64_ADDR32 cannot be used against local symbol; recompile with -fPIC
>>> defined in libs/ardour/cycle_timer.cc.1.o
>>> referenced by cycle_timer.cc
>>>               libs/ardour/cycle_timer.cc.1.o:(__ftr_fixup+0x8)

Recompiling with -fPIC doesn't help, so use GNU ld there.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2020-01-12 02:22:37 UTC
^Triage: Reporter is committer, assign accordingly
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2020-01-12 02:24:04 UTC
Comment on attachment 210645 [details]
patch

Approved by: portmgr (blanket: build fix)
MFH: 2020Q1 (blanket: build fix)
Comment 3 commit-hook freebsd_committer 2020-01-12 03:00:02 UTC
A commit references this bug:

Author: pkubaj
Date: Sun Jan 12 02:59:42 UTC 2020
New revision: 522745
URL: https://svnweb.freebsd.org/changeset/ports/522745

Log:
  audio/ardour5: fix build on powerpc64

  _POSIX_SOURCE causes some errors in errno.h not to be seen (like EAFNOSUPPORT), so remove it.

  On ELFv2 lld can't link it, throws errors like:
  ld: error: relocation R_PPC64_ADDR32 cannot be used against local symbol; recompile with -fPIC
  >>> defined in libs/ardour/cycle_timer.cc.1.o
  >>> referenced by cycle_timer.cc
  >>>               libs/ardour/cycle_timer.cc.1.o:(__ftr_fixup+0x8)

  Recompiling with -fPIC doesn't help, so use GNU ld there.

  PR:		243281
  Approved by:	portmgr (blanket: build fix)
  MFH:		2020Q1 (blanket: build fix)

Changes:
  head/audio/ardour5/Makefile
  head/audio/ardour5/files/
  head/audio/ardour5/files/patch-libs_fst_wscript
Comment 4 commit-hook freebsd_committer 2020-01-12 03:01:03 UTC
A commit references this bug:

Author: pkubaj
Date: Sun Jan 12 03:00:45 UTC 2020
New revision: 522746
URL: https://svnweb.freebsd.org/changeset/ports/522746

Log:
  MFH: r522745

  audio/ardour5: fix build on powerpc64

  _POSIX_SOURCE causes some errors in errno.h not to be seen (like EAFNOSUPPORT), so remove it.

  On ELFv2 lld can't link it, throws errors like:
  ld: error: relocation R_PPC64_ADDR32 cannot be used against local symbol; recompile with -fPIC
  >>> defined in libs/ardour/cycle_timer.cc.1.o
  >>> referenced by cycle_timer.cc
  >>>               libs/ardour/cycle_timer.cc.1.o:(__ftr_fixup+0x8)

  Recompiling with -fPIC doesn't help, so use GNU ld there.

  PR:		243281
  Approved by:	portmgr (blanket: build fix)

Changes:
_U  branches/2020Q1/
  branches/2020Q1/audio/ardour5/Makefile
  branches/2020Q1/audio/ardour5/files/