Bug 243372 - www/nginx: Add 3rd party module nginx-link-function
Summary: www/nginx: Add 3rd party module nginx-link-function
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jochen Neumeister
URL: https://github.com/Taymindis/nginx-li...
Keywords: feature, needs-patch
Depends on:
Blocks:
 
Reported: 2020-01-15 13:27 UTC by Philipp Engel
Modified: 2020-01-24 17:51 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (joneum)


Attachments
shar archive (33.15 KB, text/plain)
2020-01-15 13:27 UTC, Philipp Engel
no flags Details
Makefile.extmod.patch (482 bytes, patch)
2020-01-15 20:47 UTC, Philipp Engel
no flags Details | Diff
Makefile.options.desc.patch (436 bytes, patch)
2020-01-15 20:47 UTC, Philipp Engel
no flags Details | Diff
Makefile.patch (652 bytes, patch)
2020-01-15 20:47 UTC, Philipp Engel
no flags Details | Diff
Makefile.extmod.patch (482 bytes, patch)
2020-01-15 20:50 UTC, Philipp Engel
no flags Details | Diff
Makefile.options.desc.patch (436 bytes, patch)
2020-01-15 20:51 UTC, Philipp Engel
no flags Details | Diff
Makefile.patch (652 bytes, patch)
2020-01-15 20:51 UTC, Philipp Engel
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philipp Engel 2020-01-15 13:27:35 UTC
Created attachment 210758 [details]
shar archive

This shar archive adds the 3rd party module nginx-link-function [1] to nginx. Unfortunately, I couldn't fully test it, as "make makesum" creates only a checksum for nginx itself, not for the modules. Advice is welcome.

[1] https://github.com/Taymindis/nginx-link-function/
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2020-01-15 20:41:19 UTC
Thank you for the report and patch Philipp

Could you provide your proposal as a patch (unified diff: diff -u or svn diff) please
Comment 2 Philipp Engel 2020-01-15 20:47:14 UTC
Created attachment 210770 [details]
Makefile.extmod.patch
Comment 3 Philipp Engel 2020-01-15 20:47:37 UTC
Created attachment 210771 [details]
Makefile.options.desc.patch
Comment 4 Philipp Engel 2020-01-15 20:47:54 UTC
Created attachment 210772 [details]
Makefile.patch
Comment 5 Philipp Engel 2020-01-15 20:50:45 UTC
Created attachment 210773 [details]
Makefile.extmod.patch
Comment 6 Philipp Engel 2020-01-15 20:51:27 UTC
Created attachment 210774 [details]
Makefile.options.desc.patch
Comment 7 Philipp Engel 2020-01-15 20:51:49 UTC
Created attachment 210775 [details]
Makefile.patch
Comment 8 Philipp Engel 2020-01-15 20:52:58 UTC
Sorry, I smoked myself retarded. Please see the attached patches.
Comment 9 Jochen Neumeister freebsd_committer 2020-01-20 14:37:18 UTC
Heya Phillipp,

thanks for the PR :-)
I will build it in the days
Comment 10 commit-hook freebsd_committer 2020-01-22 13:27:22 UTC
A commit references this bug:

Author: joneum
Date: Wed Jan 22 13:26:56 UTC 2020
New revision: 523807
URL: https://svnweb.freebsd.org/changeset/ports/523807

Log:
  Add 3rd party module nginx-link-function

  https://github.com/Taymindis/nginx-link-function/

  PR:		243372
  Sponsored by:	Netzkommune GmbH

Changes:
  head/www/nginx/Makefile
  head/www/nginx/Makefile.extmod
  head/www/nginx/Makefile.options.desc
  head/www/nginx/distinfo
Comment 11 Philipp Engel 2020-01-22 19:56:39 UTC
Thank you, Jochen! Unfortunately, the port fails to build with Poudriere:

checking for ngx_http_link_func ... not found
ngx_link_func_module.h not found in your system c header path, please copy latest ngx_link_func_module.h to your /usr/include or /usr/local/include or relavent header search path with read and write permission given.
e.g install -m 644 ../nginx-link-function/src/ngx_link_func_module.h /usr/local/include/

But adding the header file to the /usr/local/include/ path of the Poudriere Jail doesn't help either. Do you happen to know the correct include path?
Comment 12 Sergey A. Osokin freebsd_committer 2020-01-24 17:51:07 UTC
Hi Philipp,

I've just briefly taken a look on the code, so I'd recommend to patch the third-party module to make it buildable.