Bug 243506 - textproc/libdiff: wrong license?
Summary: textproc/libdiff: wrong license?
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Baptiste Daroussin
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2020-01-22 10:59 UTC by John Hein
Modified: 2020-03-24 16:57 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (bapt)


Attachments
[patch] MIT license for libdiff (327 bytes, patch)
2020-01-22 10:59 UTC, John Hein
jcfyecrayz: maintainer-approval? (bapt)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2020-01-22 10:59:43 UTC
Created attachment 210952 [details]
[patch] MIT license for libdiff

textproc/libdiff is marked with the ISCL, but it's not clear why.

The documentation (README.md) for the project says all sources are MIT licensed.  Except for a collection of compatibility shims in compats.c (which contain a combination of ISCL and BSD licensed software... and some public domain), inspection confirms the statement in README.md.

What prompted this port to be marked as using ISCL?

<later...> I see tests.c also has the ISCL.  But tests.c is used for configure - it is not included in the library.

If you agree that the port is MIT licensed, apply the obvious patch (attached).  

This port _could_ be marked with more than one license because of the compatibility shims, but the libdiff-specific content is all MIT licensed.

After configuring & building libdiff on freebsd (11), the only code built in compats.c is the MD5 shims (public domain) and recallocarray.  Neither is used by libdiff.  I think the compats stuff (and configure & tests.c) were probably copied from another project to bootstrap configuration-time infrastructure for libdiff and not all of the shims are needed for libdiff.

So based on that analysis, I think it is correct to only mark the libdiff port (as built on FreeBSD) with the MIT license.
Comment 1 Automation User 2020-02-06 00:04:55 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/115372987
Comment 2 Baptiste Daroussin freebsd_committer 2020-03-24 16:57:30 UTC
thank you!
Comment 3 commit-hook freebsd_committer 2020-03-24 16:57:41 UTC
A commit references this bug:

Author: bapt
Date: Tue Mar 24 16:57:15 UTC 2020
New revision: 529052
URL: https://svnweb.freebsd.org/changeset/ports/529052

Log:
  Fix wrong license information it is MIT not ISCL

  PR:		243506
  Submitted by:	John Hein <jcfyecrayz@liamekaens.com>

Changes:
  head/textproc/libdiff/Makefile