Bug 243575 - graphics/pinta: Update to 1.6
Summary: graphics/pinta: Update to 1.6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2020-01-24 23:43 UTC by OlivierW
Modified: 2021-05-08 09:35 UTC (History)
3 users (show)

See Also:
koobs: maintainer-feedback? (olivierw1+bugzilla-freebsd)

Attachments
Pinta 1.5 to 1.6 update (10.45 KB, patch)
2020-01-24 23:43 UTC, OlivierW 		olivierw1+bugzilla-freebsd: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description OlivierW 2020-01-24 23:43:06 UTC 
Created attachment 211022 [details]
Pinta 1.5 to 1.6 update

Hello,

Please find attached a patch to update Pinta 1.5 to 1.6.

I had quite a hard time creating a clean patch, I'm not sure it's the best. I created a local git repo and used "git diff", since I couldn't find an easy command to make a patch which create new files in "files" folder.

To apply it in your "graphics/pinta", use:
patch -p1 < pinta-1.6.patch
The remove the .orig files with:
rm files/*.orig *.orig
Then build with poudriere :-)

Tested on FreeBSD 12.1 amd64.


I compared my previous "pinta-1.5-7b61a772f9.txz" with the new "pinta-1.6-bd0e24464a.txz", and somehow the new version is missing 3 files:
/usr/local/share/licenses/pinta-1.5/catalog.mk
/usr/local/share/licenses/pinta-1.5/LICENSE
/usr/local/share/licenses/pinta-1.5/MIT

Is it normal? Where do they normally comes from?

Best Regards,
Olivier
Comment 1 OlivierW 2020-01-24 23:52:19 UTC 
I forgot to add: the original patch creating the "files/patch-Pinta.*" files comes from:
https://launchpadlibrarian.net/257693583/Pinta-1.6_mono4.patch
which I found attached to this issue:
https://bugs.launchpad.net/pinta/+bug/1523739
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2020-01-25 02:29:35 UTC 
Thanks Olivier! Don't forget to set the maintainer-approval attachment flag (to +) to signify maintainer approval for patches to ports you maintain. Attachment -> Details -> maintainer-approval [+], or set it during attachment upload
Comment 3 OlivierW 2020-01-25 08:09:42 UTC 
Thanks Kubilay, I just added the flag :-)
Comment 4 Li-Wen Hsu freebsd_committer 2020-08-13 08:46:48 UTC 
koobs: are you still interested in handling this patch?
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2020-08-13 09:43:50 UTC 
(In reply to Li-Wen Hsu from comment #4)

Happy for you to take it if you like, but this is not a blind patch commit, and has additional context associated with it (see bug 243471)

@Olivier Is this patch still good to go or do we need some tweaks/changes/updates?
Comment 6 OlivierW 2020-11-01 19:42:05 UTC 
(In reply to Kubilay Kocak from comment #5)
Hello!

I know I am very late, but yes, the patch is still good! :-)
Comment 7 commit-hook freebsd_committer 2021-05-08 09:32:52 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=970a21a2f2924c9b7bfacd5275651905ead4d660

commit 970a21a2f2924c9b7bfacd5275651905ead4d660
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2021-05-08 09:24:12 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2021-05-08 09:30:59 +0000

    Belatedly update Pinta to version 1.7.

    PR:     243575

 graphics/pinta/Makefile  |  5 ++---
 graphics/pinta/distinfo  |  6 +++---
 graphics/pinta/pkg-plist | 12 ++++++++++++
 3 files changed, 17 insertions(+), 6 deletions(-)
Comment 8 Alexey Dokuchaev freebsd_committer 2021-05-08 09:35:23 UTC 
Port had been updated to version 1.7, thanks; no additional patches are necessary to build against current Mono stack offered by the ports.