Bug 243605 - Flakey test case: sys.kern.ptrace_test.ptrace__procdesc_reparent_wait_child
Summary: Flakey test case: sys.kern.ptrace_test.ptrace__procdesc_reparent_wait_child
Status: New
Alias: None
Product: Base System
Classification: Unclassified
Component: tests (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-testing (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-26 07:20 UTC by Li-Wen Hsu
Modified: 2021-03-01 19:57 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Li-Wen Hsu freebsd_committer 2020-01-26 07:20:20 UTC
https://ci.freebsd.org/job/FreeBSD-head-amd64-test/14073/testReport/junit/sys.kern/ptrace_test/ptrace__procdesc_reparent_wait_child/

Error Message

/usr/src/tests/sys/kern/ptrace_test.c:4224: WEXITSTATUS(status) == 0 not met
Comment 1 commit-hook freebsd_committer 2020-01-26 07:25:21 UTC
A commit references this bug:

Author: lwhsu
Date: Sun Jan 26 07:24:50 UTC 2020
New revision: 357137
URL: https://svnweb.freebsd.org/changeset/base/357137

Log:
  Temporarily skip flakey test case sys.kern.ptrace_test.ptrace__procdesc_reparent_wait_child

  PR:		243605
  Sponsored by:	The FreeBSD Foundation

Changes:
  head/tests/sys/kern/ptrace_test.c
Comment 2 commit-hook freebsd_committer 2021-03-01 19:57:18 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=1032131464f1196ad674b30c14a9e611789a1061

commit 1032131464f1196ad674b30c14a9e611789a1061
Author:     Alex Richardson <arichardson@FreeBSD.org>
AuthorDate: 2021-03-01 18:51:02 +0000
Commit:     Alex Richardson <arichardson@FreeBSD.org>
CommitDate: 2021-03-01 19:56:05 +0000

    Remove atf_tc_skip calls from ptrace_test

    I've run these tests many times in a loop on multiple architectures and
    it works reliably for me, maybe it's time to retire these skips?
    This also adds an additional waitpid to one of the tests to avoid
    a potential race condition (suggested by markj@).

    PR:             239397, 244056, 239425, 240510, 220841, 243605
    Reviewed By:    markj
    Differential Revision: https://reviews.freebsd.org/D28888

 tests/sys/kern/ptrace_test.c | 29 ++---------------------------
 1 file changed, 2 insertions(+), 27 deletions(-)
Comment 3 commit-hook freebsd_committer 2021-03-01 19:57:21 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/src/commit/?id=96a9e50e63bfcbca7309c012c2c7a477c8826824

commit 96a9e50e63bfcbca7309c012c2c7a477c8826824
Author:     Alex Richardson <arichardson@FreeBSD.org>
AuthorDate: 2021-03-01 18:49:31 +0000
Commit:     Alex Richardson <arichardson@FreeBSD.org>
CommitDate: 2021-03-01 19:55:43 +0000

    ptrace_test: Add more debug output on test failures

    Mostly automatic, using
    `CHILD_REQUIRE\(([^|&\n]*) ==` -> `CHILD_REQUIRE_EQ_INT($1,`
    `ATF_REQUIRE\(([^|&\n]*) ==` -> `REQUIRE_EQ_INT($1,` followed by
    git-clang-format -f and then manually checking ones that contain ||/&&.

    Test Plan:
    Still getting the same failure but now it prints
    `psr.sr_error (0) == EBADF (9) not met` instead of just failing
    without printing the values.

    PR:             243605
    Reviewed By:    jhb
    Differential Revision: https://reviews.freebsd.org/D28887

 tests/sys/kern/ptrace_test.c | 1516 +++++++++++++++++++++---------------------
 1 file changed, 770 insertions(+), 746 deletions(-)