Bug 243670 - games/openfodder: fix build on GCC architectures
Summary: games/openfodder: fix build on GCC architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-28 12:48 UTC by Piotr Kubaj
Modified: 2020-01-29 10:30 UTC (History)
1 user (show)

See Also:
pkubaj: maintainer-feedback? (jbeich)
jbeich: merge-quarterly+


Attachments
patch (841 bytes, patch)
2020-01-28 12:48 UTC, Piotr Kubaj
pkubaj: maintainer-approval? (jbeich)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2020-01-28 12:48:42 UTC
Created attachment 211129 [details]
patch

GCC9 needs sys/types.h in Source/Utils/SimplexIslands.hpp for int32_t:
In file included from Source/Utils/SimplexIslands.cpp:2:
Source/Utils/SimplexIslands.hpp:65:16: error: 'int32_t' does not name a type
   65 |  static inline int32_t fastfloor(double fp) {
      |                ^~~~~~~
Source/Utils/SimplexIslands.hpp: In member function 'double SimplexIslands::noise(double, double)':
Source/Utils/SimplexIslands.hpp:79:11: error: 'fastfloor' was not declared in this scope
   79 |   int i = fastfloor(xin + s);
      |           ^~~~~~~~~
Comment 1 commit-hook freebsd_committer 2020-01-29 03:38:05 UTC
A commit references this bug:

Author: jbeich
Date: Wed Jan 29 03:37:59 UTC 2020
New revision: 524531
URL: https://svnweb.freebsd.org/changeset/ports/524531

Log:
  games/openfodder: unbreak with GCC after r521658

  In file included from Source/Utils/SimplexIslands.cpp:2:
  Source/Utils/SimplexIslands.hpp:65:16: error: 'int32_t' does not name a type
     65 |  static inline int32_t fastfloor(double fp) {
        |                ^~~~~~~
  Source/Utils/SimplexIslands.hpp: In member function 'double SimplexIslands::noise(double, double)':
  Source/Utils/SimplexIslands.hpp:79:11: error: 'fastfloor' was not declared in this scope
     79 |   int i = fastfloor(xin + s);
        |           ^~~~~~~~~

  PR:		243670
  Submitted by:	pkubaj

Changes:
  head/games/openfodder/Makefile
  head/games/openfodder/distinfo
Comment 2 commit-hook freebsd_committer 2020-01-29 03:39:06 UTC
A commit references this bug:

Author: jbeich
Date: Wed Jan 29 03:38:42 UTC 2020
New revision: 524532
URL: https://svnweb.freebsd.org/changeset/ports/524532

Log:
  MFH: r524531

  games/openfodder: unbreak with GCC after r521658

  In file included from Source/Utils/SimplexIslands.cpp:2:
  Source/Utils/SimplexIslands.hpp:65:16: error: 'int32_t' does not name a type
     65 |  static inline int32_t fastfloor(double fp) {
        |                ^~~~~~~
  Source/Utils/SimplexIslands.hpp: In member function 'double SimplexIslands::noise(double, double)':
  Source/Utils/SimplexIslands.hpp:79:11: error: 'fastfloor' was not declared in this scope
     79 |   int i = fastfloor(xin + s);
        |           ^~~~~~~~~

  PR:		243670
  Submitted by:	pkubaj
  Approved by:	ports-secteam blanket

Changes:
_U  branches/2020Q1/
  branches/2020Q1/games/openfodder/Makefile
  branches/2020Q1/games/openfodder/distinfo