Bug 243676 - geom_eli geli: Erroneously accepts weak (short) keys
Summary: geom_eli geli: Erroneously accepts weak (short) keys
Status: New
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-geom (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-28 17:23 UTC by Conrad Meyer
Modified: 2020-01-28 17:25 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Conrad Meyer freebsd_committer freebsd_triage 2020-01-28 17:23:27 UTC 
Entropy is cheap.  We should reject keyfiles smaller than 256 bits at initialization time.  At attach, we should clearly continue allowing people to access their existing volumes, but maybe a warning would be appropriate?  Today, GELI allows initialization with small and empty keyfiles (init -K, attach -k).  These should be rejected.