Bug 243691 - dns/knot-resolver: manpage not installed correctly
Summary: dns/knot-resolver: manpage not installed correctly
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-29 03:43 UTC by sigsys
Modified: 2020-01-30 13:26 UTC (History)
2 users (show)

See Also:
freebsd: maintainer-feedback-


Attachments
knot-resolver man patch (808 bytes, patch)
2020-01-29 13:23 UTC, Leo Vandewoestijne
freebsd: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description sigsys 2020-01-29 03:43:38 UTC
The manpage ends up in at /usr/local/man8/kresd.8 instead of /usr/local/man/man8/kresd.8.gz.  So doing a "man kresd" doesn't find it.

Index: dns/knot-resolver/Makefile
===================================================================
--- dns/knot-resolver/Makefile	(revision 524526)
+++ dns/knot-resolver/Makefile	(working copy)
@@ -48,7 +48,7 @@
 CONFLICTS=	knot-1.* knot1-[0-6].*
 
 MESON_ARGS=	--default-library=static \
-		--mandir=${MANPREFIX} \
+		--mandir=${MANPREFIX}/man \
 		--prefix=${LOCALBASE} \
 		-Dsystemd=false
 #MESON_ARGS+=	--libdir=${PREFIX}/lib
Index: dns/knot-resolver/pkg-plist
===================================================================
--- dns/knot-resolver/pkg-plist	(revision 524526)
+++ dns/knot-resolver/pkg-plist	(working copy)
@@ -85,7 +85,7 @@
 lib/knot-resolver/zonefile.lua
 lib/libkres.a
 libdata/pkgconfig/libkres.pc
-man8/kresd.8
+man/man8/kresd.8.gz
 sbin/kres-cache-gc
 sbin/kresc
 sbin/kresd
Comment 1 Leo Vandewoestijne 2020-01-29 13:21:23 UTC
Acknowlegding the problem.

Just tested the patch, and approving it.
Thanks for providing the solution.

Further I expect to have the 5.0.0 upgrade ready after the weekend.
I will keep an eye if this occurs also there - or is already correct.
Comment 2 Leo Vandewoestijne 2020-01-29 13:23:18 UTC
Created attachment 211162 [details]
knot-resolver man patch

Exact same patch.
Comment 3 sigsys 2020-01-29 21:02:27 UTC
(In reply to Leo Vandewoestijne from comment #1)
Alright, great! I'll probably be testing 5.0.0 after you upgrade it. Thanks.
Comment 4 Leo Vandewoestijne 2020-01-30 13:11:25 UTC
That will be PR 243729
(to not cause trouble with that one I drop approval of your perfectly fine solution)
Could you please close this one? (I can't)
Comment 5 Walter Schwarzenfeld freebsd_triage 2020-01-30 13:26:00 UTC
Close here, as desired.