Bug 243696 - databases/mariadb103-server upgrade to 10.3.22
Summary: databases/mariadb103-server upgrade to 10.3.22
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs mailing list
URL: https://mariadb.com/kb/en/mariadb-103...
Keywords:
Depends on:
Blocks:
 
Reported: 2020-01-29 05:23 UTC by Santhosh Raju
Modified: 2020-01-30 07:18 UTC (History)
1 user (show)

See Also:
fox: maintainer-feedback? (brnrd)
fox: merge-quarterly?


Attachments
Patch to update the ports script to support mariadb103-server 10.3.22 builds. (2.04 KB, patch)
2020-01-29 05:23 UTC, Santhosh Raju
fox: maintainer-approval? (brnrd)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Santhosh Raju freebsd_committer 2020-01-29 05:23:19 UTC
Created attachment 211153 [details]
Patch to update the ports script to support mariadb103-server 10.3.22 builds.

MariaDB has been updated to 10.3.22, and this also fixes some of the security vulnerabilities mentioned in 

https://vuxml.freebsd.org/freebsd/a6cf65ad-37d2-11ea-a1c7-b499baebfeaf.html

I have made a patch that updates the ports script to support building 10.3.22, the patch was tested in poudriere (11.3/12.1) and also did a local build in my machine (12.1-RELEASE/13.0-CURRENT) with all options enabled and it builds, installs and runs fine.

Let me know if this patch looks good and if it can be committed to the ports tree.

Build logs.

https://trouble.is/pkg/data/11i386-fox-fox/2020-01-29_04h37m41s/logs/mariadb103-server-10.3.22.log
https://trouble.is/pkg/data/11amd64-fox-fox/2020-01-29_04h37m42s/logs/mariadb103-server-10.3.22.log
https://trouble.is/pkg/data/12i386-fox-fox/2020-01-29_04h37m39s/logs/mariadb103-server-10.3.22.log
https://trouble.is/pkg/data/12amd64-fox-fox/2020-01-29_05h02m49s/logs/mariadb103-server-10.3.22.log

Thank you
Comment 1 Bernard Spil freebsd_committer 2020-01-29 18:59:06 UTC
Hi Santosh,

Thanks for the patch, working on it!

Can you please have a look at https://jira.mariadb.org/browse/MDEV-21592 and see if that's sufficient? This fix will find its way back into upstream.

Cheers, Bernard.
Comment 2 Bernard Spil freebsd_committer 2020-01-29 21:35:36 UTC
Dang! Forgot to reference the PR in the commit...

Has landed with an svn cp of the 10.4 patch (upstream reported) with r524607
Comment 3 Santhosh Raju freebsd_committer 2020-01-29 23:15:58 UTC
(In reply to Bernard Spil from comment #1)

Sorry to comment on the closed thread, but shouldn't the patch also consider

#if defined(__FreeBSD__)
#define pam_syslog(...)
#endif

Couldn't find a proper reference to that but this may be this section of the diff helps.

https://github.com/KDE/kwallet-pam/blob/master/pam_kwallet.c#L62


But otherwise it looks good to me.
Comment 4 Bernard Spil freebsd_committer 2020-01-30 07:18:38 UTC
Hi Santosh,

Build would have failed if pam_syslog were used anywhere in the code. Apparently, no calls to pam_syslog are used in MariaDB's code.

Cheers, Bernard.