Bug 243834 - sysutils/fdupes: libpcre2 dependency is only needed when building with ncurses
Summary: sysutils/fdupes: libpcre2 dependency is only needed when building with ncurses
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-03 07:04 UTC by Terry Kennedy
Modified: 2020-02-09 15:44 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (ehaupt)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Terry Kennedy 2020-02-03 07:04:44 UTC
In the present state of the sysutils/fdupes port, there is an uncondional
LIB_DEPENDS=    libpcre2-32.so:devel/pcre2
in the port Makefile. However, the fdupes "INSTALL.enduser" file correctly states:
==SNIP==
 9 Starting with fdupes 2.0.0, a full-featured installation requires 
10 the following libraries to be installed on your system: 
11 
12   - ncursesw (ncurses with support for wide characters) 
13   - PCRE2 (Perl Compatible Regular Expressions library) 
14 
15 Source code for these libraries is available at: 
16 
17   https://www.gnu.org/software/ncurses/ 
18   https://www.pcre.org/ 
19 
20 If these libraries are not available on your system or you want to 
21 build fdupes without them, you may instead call configure as: 
22 
23 	./configure --without-ncurses 
==SNIP==

Can we get this port's Makefile changed to only require libpcre2 if the
ncurses option is selected? This will avoid dragging in pcre2 and friends
on systems that do not already have it installed and do not need ehanced
fdupes functionality.
Comment 1 commit-hook freebsd_committer 2020-02-03 09:54:14 UTC
A commit references this bug:

Author: ehaupt
Date: Mon Feb  3 09:53:43 UTC 2020
New revision: 525025
URL: https://svnweb.freebsd.org/changeset/ports/525025

Log:
  libpcre2 is only needed in combination with ncurses.

  PR:		243834 (based on)
  Submitted by:	terry-freebsd@glaver.org
  MFH:		2020Q1

Changes:
  head/sysutils/fdupes/Makefile
Comment 2 Emanuel Haupt freebsd_committer 2020-02-03 09:55:05 UTC
Update committed, thanks!
Comment 3 commit-hook freebsd_committer 2020-02-09 15:44:29 UTC
A commit references this bug:

Author: ehaupt
Date: Sun Feb  9 15:44:20 UTC 2020
New revision: 525661
URL: https://svnweb.freebsd.org/changeset/ports/525661

Log:
  MFH: r525025

  libpcre2 is only needed in combination with ncurses.

  PR:		243834 (based on)
  Submitted by:	terry-freebsd@glaver.org
  Approved by:	ports-secteam (miwi)

Changes:
_U  branches/2020Q1/
  branches/2020Q1/sysutils/fdupes/Makefile