Bug 243938 - devel/sasm: Update to 3.11.1
Summary: devel/sasm: Update to 3.11.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mateusz Piotrowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-06 19:33 UTC by Martin Filla
Modified: 2020-02-08 01:11 UTC (History)
1 user (show)

See Also:
freebsd: maintainer-feedback+

Attachments
sasm.diff (838 bytes, patch)
2020-02-06 19:33 UTC, Martin Filla 		no flags Details | Diff
sasm.diff (857 bytes, patch)
2020-02-06 19:38 UTC, Martin Filla 		freebsd: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Filla 2020-02-06 19:33:02 UTC 
Created attachment 211422 [details]
sasm.diff

hi, update sasm version
Comment 1 Martin Filla 2020-02-06 19:38:25 UTC 
Created attachment 211423 [details]
sasm.diff
Comment 2 Mateusz Piotrowski freebsd_committer freebsd_triage 2020-02-08 00:18:04 UTC 
Taking a look
Comment 3 Mateusz Piotrowski freebsd_committer freebsd_triage 2020-02-08 01:09:18 UTC 
I encourage you to build your submissions in poudriere. It catches most problems you might encounter when developing ports. For example, the sasm binary is not stripped currently and I got the warning about it from poudriere. ;)

Otherwise, seems fine. I'm going to commit.
Comment 4 Mateusz Piotrowski freebsd_committer freebsd_triage 2020-02-08 01:10:56 UTC 
Thanks for your patch!
Comment 5 commit-hook freebsd_committer freebsd_triage 2020-02-08 01:11:29 UTC 
A commit references this bug:

Author: 0mp
Date: Sat Feb  8 01:10:30 UTC 2020
New revision: 525514
URL: https://svnweb.freebsd.org/changeset/ports/525514

Log:
  Update to 3.11.1

  - Sort variables
  - Strip the final binary

  PR:		243938
  Submitted by:	Martin Filla <freebsd@sysctl.cz> (maintainer)

Changes:
  head/devel/sasm/Makefile
  head/devel/sasm/distinfo