Bug 243967 - [NEW PORT] net-p2p/bazarr: Automatic subtitle downloader for Sonarr and Radarr
Summary: [NEW PORT] net-p2p/bazarr: Automatic subtitle downloader for Sonarr and Radarr
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: feature, needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2020-02-07 22:27 UTC by Michiel van Baak
Modified: 2020-10-26 11:47 UTC (History)
5 users (show)

See Also:
michiel: maintainer-feedback+


Attachments
bazarr-0.8.4.1.diff (183.43 KB, patch)
2020-02-07 22:27 UTC, Michiel van Baak
no flags Details | Diff
bazarr-0.8.4.2.diff (396.58 KB, patch)
2020-03-01 15:16 UTC, Michiel van Baak
no flags Details | Diff
bazarr-0.8.4.2.diff (394.21 KB, patch)
2020-03-03 13:39 UTC, Michiel van Baak
no flags Details | Diff
bazanrr-0.8.4.4.diff (404.04 KB, patch)
2020-06-08 11:22 UTC, Michiel van Baak
michiel: maintainer-approval+
Details | Diff
bazarr-0.9.0.2.diff (523.07 KB, patch)
2020-08-26 10:37 UTC, Michiel van Baak
michiel: maintainer-approval+
Details | Diff
bazarr-0.9.0.5.diff (529.43 KB, patch)
2020-10-25 11:21 UTC, Michiel van Baak
michiel: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michiel van Baak 2020-02-07 22:27:02 UTC
Created attachment 211458 [details]
bazarr-0.8.4.1.diff

Bazarr is a companion application to Sonarr and Radarr.
It manages and downloads subtitles based on your requirements.
You define your preferences by TV show or movie
and Bazarr takes care of everything for you.

* portlint ok

Tested and running correctly on FreeBSD 12.1-RELEASE amd64
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2020-02-08 13:02:14 UTC
Review items:

- Upstream supports [1][2] Python 3.6+ (testing up to 3.8). USES=python:<version-spec> should be 3.6+ or 3.6-3.8

- lxml RUN_DEPENDS version specifier should match the version specified in upstream requirements.txt (>=4.3.0)

- All importable .py files need to be optimized/processed (pyc/pyo files). Ports using distutils (setuptools) and autoplist handle this automatically. This packages doesnt use setuptools (ask them to package and ship this via PyPI please).

Not doing so means that the pyc/pyo files will be created at run time, thereby leaving pyc/pyo orphaned files leftover after pkg removal (since they're not referenced in the pkg-plist)

Use a post-install: Python "compileall" script (provided examples/references via IRC) to process all .py files and include them in the pkg-plist.

Note: the net-p2p/couchpotato port, which this port was based on, is also affected by this (only packaging .py files)

[1] "bazarr require Python 3.6 or greater and can be run from source."
[2] "Install Python 3.6 or greater (latest is good)"
Comment 2 Michiel van Baak 2020-02-08 14:10:59 UTC
Comment on attachment 211458 [details]
bazarr-0.8.4.1.diff

Upstream needs some work first.
Comment 3 Michiel van Baak 2020-03-01 15:16:29 UTC
Created attachment 212077 [details]
bazarr-0.8.4.2.diff

Added new port bazarr.

portlint: OK
Tested and works on 12.1-RELEASE amd64

Setting up poudriere now to run testport on it.
Comment 4 Michiel van Baak 2020-03-03 13:39:21 UTC
Created attachment 212117 [details]
bazarr-0.8.4.2.diff

Removed unusable binaries and header files from source, cleaning up the installed files list a bit.

testport: 12.1-RELEASE amd64: OK
portlint: OK

Running 'in production' on my home setup (12.1-RELEASE-p2)
Comment 5 Andrej Ebert 2020-03-07 13:10:19 UTC
(In reply to Michiel van Baak from comment #4)
Works on my home server too, without any problems. Was looking into making a port myself, when I found this PR. Thanks!
Comment 6 Michiel van Baak 2020-06-08 11:22:01 UTC
Created attachment 215356 [details]
bazanrr-0.8.4.4.diff
Comment 7 Michiel van Baak 2020-08-26 10:37:47 UTC
Created attachment 217536 [details]
bazarr-0.9.0.2.diff
Comment 8 Michiel van Baak 2020-10-25 11:21:25 UTC
Created attachment 219056 [details]
bazarr-0.9.0.5.diff
Comment 9 daniel.engberg.lists 2020-10-25 13:44:01 UTC
Is it possible to unbundle libraries?
https://www.freebsd.org/doc/en/books/porters-handbook/book.html#bundled-libs
Comment 10 Michiel van Baak 2020-10-26 11:47:01 UTC
(In reply to daniel.engberg.lists from comment #9)

Yeah, that's probably better. I'll give it a shot later.