Created attachment 211458 [details] bazarr-0.8.4.1.diff Bazarr is a companion application to Sonarr and Radarr. It manages and downloads subtitles based on your requirements. You define your preferences by TV show or movie and Bazarr takes care of everything for you. * portlint ok Tested and running correctly on FreeBSD 12.1-RELEASE amd64
Review items: - Upstream supports [1][2] Python 3.6+ (testing up to 3.8). USES=python:<version-spec> should be 3.6+ or 3.6-3.8 - lxml RUN_DEPENDS version specifier should match the version specified in upstream requirements.txt (>=4.3.0) - All importable .py files need to be optimized/processed (pyc/pyo files). Ports using distutils (setuptools) and autoplist handle this automatically. This packages doesnt use setuptools (ask them to package and ship this via PyPI please). Not doing so means that the pyc/pyo files will be created at run time, thereby leaving pyc/pyo orphaned files leftover after pkg removal (since they're not referenced in the pkg-plist) Use a post-install: Python "compileall" script (provided examples/references via IRC) to process all .py files and include them in the pkg-plist. Note: the net-p2p/couchpotato port, which this port was based on, is also affected by this (only packaging .py files) [1] "bazarr require Python 3.6 or greater and can be run from source." [2] "Install Python 3.6 or greater (latest is good)"
Comment on attachment 211458 [details] bazarr-0.8.4.1.diff Upstream needs some work first.
Created attachment 212077 [details] bazarr-0.8.4.2.diff Added new port bazarr. portlint: OK Tested and works on 12.1-RELEASE amd64 Setting up poudriere now to run testport on it.
Created attachment 212117 [details] bazarr-0.8.4.2.diff Removed unusable binaries and header files from source, cleaning up the installed files list a bit. testport: 12.1-RELEASE amd64: OK portlint: OK Running 'in production' on my home setup (12.1-RELEASE-p2)
(In reply to Michiel van Baak from comment #4) Works on my home server too, without any problems. Was looking into making a port myself, when I found this PR. Thanks!
Created attachment 215356 [details] bazanrr-0.8.4.4.diff
Created attachment 217536 [details] bazarr-0.9.0.2.diff
Created attachment 219056 [details] bazarr-0.9.0.5.diff
Is it possible to unbundle libraries? https://www.freebsd.org/doc/en/books/porters-handbook/book.html#bundled-libs
(In reply to daniel.engberg.lists from comment #9) Yeah, that's probably better. I'll give it a shot later.