Bug 243988 - x11/slim r408067 breaks consolekit2 active session state
Summary: x11/slim r408067 breaks consolekit2 active session state
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jesper Schmitz Mouridsen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-08 19:56 UTC by Jesper Schmitz Mouridsen
Modified: 2020-02-18 04:53 UTC (History)
1 user (show)

See Also:
henry.hu.sh: maintainer-feedback+


Attachments
Corrects the get_x11_device for FreeBSD (265 bytes, text/plain)
2020-02-15 19:57 UTC, Jesper Schmitz Mouridsen
jsm: maintainer-approval?
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jesper Schmitz Mouridsen freebsd_committer 2020-02-08 19:56:14 UTC
The fix of bug #206050 in  ports r408067 
breaks active session state for consolekit2 sessions, 
when using slim. Avoiding slim sets the session active as usual.
e.g ck-launch-session /usr/local/bin/startlxqt in .xinitrc
does not give an active session state using slim.

If I delete the files/patch-const.h it works, but then
but #206050 might be back..
This is on FBSD 12.1
Comment 1 Jesper Schmitz Mouridsen freebsd_committer 2020-02-15 19:57:32 UTC
Created attachment 211677 [details]
Corrects the get_x11_device for FreeBSD

This extra patch results in the following when using slim to login.

#ck-list-sessions
Session1:
        unix-user = '1001'
        realname = 'Jesper Schmitz Mouridsen'
        seat = 'Seat1'
        session-type = 'x11'
        session-class = 'user'
        session-state = 'active'
        active = TRUE
        x11-display = 'unix:0.0'
        x11-display-device = '/dev/ttyv8'
        display-device = ''
        remote-host-name = ''
        is-local = TRUE
        on-since = '2020-02-15T19:52:20.005040Z'
        login-session-id = ''
        XDG_RUNTIME_DIR = '/var/run/user/1001'
        VTNr = '9'
So with the patch slim works as expected with consolekit2 AFAICT
Comment 2 Henry Hu 2020-02-18 04:52:06 UTC
Comment on attachment 211677 [details]
Corrects the get_x11_device for FreeBSD

This patch looks good to me.
Comment 3 Henry Hu 2020-02-18 04:53:11 UTC
Comment on attachment 211677 [details]
Corrects the get_x11_device for FreeBSD

However, for some reason I can't change the maintainer-approval flag.