Bug 244022 - security/openvpn-auth-ldap: switch to github code
Summary: security/openvpn-auth-ldap: switch to github code
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Matthias Andree
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-10 13:57 UTC by geoffroy desvernay
Modified: 2020-02-10 21:07 UTC (History)
0 users

See Also:
mandree: maintainer-feedback+


Attachments
svn diff security/openvpn-auth-ldap (2.46 KB, patch)
2020-02-10 13:57 UTC, geoffroy desvernay
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description geoffroy desvernay 2020-02-10 13:57:40 UTC
Created attachment 211536 [details]
svn diff security/openvpn-auth-ldap

Some fixes are included in github's 2.0.4 that were not included in the cached tarball (?)
 - RFC2307
 - OpenVPN challenge/response protocol

See https://github.com/threerings/openvpn-auth-ldap/releases

This patch makes use of github code

poudriere and production tested :)
Comment 1 Matthias Andree freebsd_committer 2020-02-10 21:06:59 UTC
Geoffroy,

the patch looks almost good, the only thing is that since the version gets increased (2.0.4 in FreeBSD versioning is higher than 2.0.4.0.s1379), we reset PORTREVISION to 0, and at that opportunity remove it, and there are further cleanups I could make. The post-patch REINPLACE had become useless, and the MAKE_JOBS_UNSAFE appears to be no longer needed.

Since I don't have a proper runtime environment with LDAP user accounts, I would like to hand over maintainership to someone who can actually test this port in practice.  Would you be willing to take over?  Just let me know.
Comment 2 commit-hook freebsd_committer 2020-02-10 21:07:43 UTC
A commit references this bug:

Author: mandree
Date: Mon Feb 10 21:06:56 UTC 2020
New revision: 525753
URL: https://svnweb.freebsd.org/changeset/ports/525753

Log:
  openvpn-auth-ldap: Update to Github 2.0.4 release.

  * Switch from a handmade SVN checkout to Github tag
  * Drop MAKE_JOBS_UNSAFE and post-patch, no longer needed

  PR:		244022
  Submitted by:	Geoffroy Desvernay

Changes:
  head/security/openvpn-auth-ldap/Makefile
  head/security/openvpn-auth-ldap/distinfo