Created attachment 211707 [details]
portscout fix and minor cleanup
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/118433112
*** This bug has been marked as a duplicate of bug 244184 ***
Franco, may I ask you to improve your cleanup? The variables order is not the standard one, please see https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-order.html .
- we normally put USE and USES_* toghether with their related variables in one unique block, i.e. without blank lines. So we would prefer if there was no blank line before USE_GITHUB;
- ONLY_FOR_ARCHS, CONFLICTS_INSTALL and PORTSCOUT should come after the USE block.
Once this is done and I have tested your patch I will commit it with my mentor (gerald@) approval.
(If you prefer to keep the blank line it is acceptable: it is not a big deal in this case.)
Created attachment 212280 [details]
second version with portlint fixes
I'm not entirely sure on ONLY_FOR_ARCHS location as portlint insists on earlier mention. I have attached a version that passes portlint, but can change it further if needed. :)
A commit references this bug:
Date: Tue Mar 10 22:03:20 UTC 2020
New revision: 528199
www/phalcon: Portscout fix and minor cleanup
Submitted by: firstname.lastname@example.org (maintainer)
Approved by: gerald (mentor)
You have put ONLY_FOR_ARCHS in the right place, please see https://www.freebsd.org/doc/en/books/porters-handbook/porting-order-broken.html .
Also, I moved back IGNORE_WITH_PHP to its original place for the reason you can read at the same link: this variable works only with USES= php, so it belongs to the USE block.
Thanks for maintaining this port!