Bug 244206 - www/py-flask-cors: Update to 3.0.8
Summary: www/py-flask-cors: Update to 3.0.8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kubilay Kocak
URL: https://github.com/corydolphin/flask-...
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-17 22:54 UTC by Stig Inge Lea Bjørnsen
Modified: 2020-02-18 03:09 UTC (History)
1 user (show)

See Also:


Attachments
SVN diff for updating www/py-flask-cors (899 bytes, patch)
2020-02-17 22:54 UTC, Stig Inge Lea Bjørnsen
koobs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stig Inge Lea Bjørnsen 2020-02-17 22:54:35 UTC
Created attachment 211731 [details]
SVN diff for updating www/py-flask-cors

The change log [1] mentions some breaking changes since version 2.1.2, but they seem very minor.

[1] https://github.com/corydolphin/flask-cors/blob/master/CHANGELOG.md
Comment 1 Stig Inge Lea Bjørnsen 2020-02-17 22:59:05 UTC
The patch passes portline. I have tested only installation of the package using Poudriere for 12.1-RELEASE-p2.
Comment 2 Stig Inge Lea Bjørnsen 2020-02-17 23:00:05 UTC
(In reply to Stig Inge Lea Bjørnsen from comment #1)
Typo, "portline" -> "portlint".
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2020-02-18 01:11:24 UTC
I already have a WIP patch for this
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2020-02-18 01:11:56 UTC
Comment on attachment 211731 [details]
SVN diff for updating www/py-flask-cors

Use maintainer-approval attachment flag (set to +) instead of the maintainer-feedback issue flag to signify maintainer approval
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2020-02-18 01:13:38 UTC
Local changes/additions:

  - Add TEST_DEPENDS and test target to make QA easy and better
  - Update COMMENT to match upstream setup.py:description
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2020-02-18 01:17:36 UTC
maketest results:

Ran 89 tests in 4.422s FAILED (failures=1)

FAIL: NoExceptionInterceptionTestCase.test_acl_uncaught_exception_500

Reported upstream: https://github.com/corydolphin/flask-cors/issues/253
Comment 7 commit-hook freebsd_committer 2020-02-18 03:05:39 UTC
A commit references this bug:

Author: koobs
Date: Tue Feb 18 03:04:59 UTC 2020
New revision: 526437
URL: https://svnweb.freebsd.org/changeset/ports/526437

Log:
  www/py-flask-cors: Update to 3.0.8 [1]

    - Tweak COMMENT to match setup.py:description (modulo portlint) [2]

  Changelog:

    https://github.com/corydolphin/flask-cors/blob/3.0.8/CHANGELOG.md

  QA:

    - Dependents (pygeopi, flexget, beets) dependency <version-specs>
      verified.

  PR:		244206
  Submitted by:	Stig Inge Lea Bj?rnsen <stiginge pvv org>  [1]
  Approved by:	portmgr (blanket: ports (Python) compliance) [2]

Changes:
  head/www/py-flask-cors/Makefile
  head/www/py-flask-cors/distinfo
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2020-02-18 03:09:13 UTC
Committed with minor additions/changes, thank you!