Bug 244212 - emulators/virtualbox-ose: Update to 5.2.42
Summary: emulators/virtualbox-ose: Update to 5.2.42
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Many People
Assignee: Kyle Evans
URL: https://www.virtualbox.org/wiki/Chang...
Keywords: needs-patch, needs-qa, security
Depends on:
Blocks:
 
Reported: 2020-02-18 10:40 UTC by Nikita Stepanov
Modified: 2020-07-02 00:14 UTC (History)
12 users (show)

See Also:
bugzilla: maintainer-feedback? (vbox)
joneum: merge-quarterly+


Attachments
VirtualBox 5.2.42 port (84.69 KB, application/gzip)
2020-05-20 00:48 UTC, Mario Lobo
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Stepanov 2020-02-18 10:40:57 UTC
https://www.virtualbox.org/wiki/Changelog-5.2#v36
Comment 1 Nikita Stepanov 2020-02-22 07:42:21 UTC
Update https://www.virtualbox.org/wiki/Changelog-5.2#v38
Comment 2 Dutchman01 2020-03-08 21:56:39 UTC
We really need to have it upgraded on the current port, please can it get some priority?
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2020-04-17 02:50:36 UTC
Kyle has a 5.2.40 update in flight
Comment 4 VVD 2020-04-17 08:03:46 UTC
There was a lot of CVE (19) fixed in 5.2.40:
https://www.oracle.com/security-alerts/cpuapr2020.html#AppendixOVIR
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2020-04-19 05:56:59 UTC
^Triage: Re-triage based on security vulnerabilities in comment 4 (Thank you VVD)
Comment 6 VVD 2020-05-16 13:07:13 UTC
5.2.42 released: https://www.virtualbox.org/wiki/Changelog-5.2#v42
Comment 7 Mario Lobo 2020-05-20 00:48:28 UTC
Created attachment 214672 [details]
VirtualBox 5.2.42 port

Fully functional port
Comment 8 Kyle Evans freebsd_committer 2020-05-20 01:09:19 UTC
(In reply to Mario Lobo from comment #7)

Hi,

Can you please reattach this as an `svn diff` instead?

Thanks,

Kyle Evans
Comment 9 Mario Lobo 2020-05-20 15:27:33 UTC
There are only 3 things that need to be done to move from 5.2.34 to 5.2.42:

1) Adjust both Makefiles (virtualbox-ose & virtualbox-ose-kmod)

change PORTVERSION=	5.2.34  to  PORTVERSION=	5.2.42
remove PORTREVISION=	4

2) remove patch-src_VBox_Devices_PC_vbox-cpuhotplug.dsl from virtualbox-ose/files

3) recalculate distinfo, which becomes this:

SHA256 (VirtualBox-5.2.42.tar.bz2) = e5bee2e34f349aac115ee93974febfe3213ad5e94045fa36b9f04b5f8caa3720
SIZE (VirtualBox-5.2.42.tar.bz2) = 124013981
SHA256 (VBoxGuestAdditions_5.2.42.iso) = ff784417295e48e3cee80a596faf05e3b0976e1b94d3b88427939912b0c1fc45
SIZE (VBoxGuestAdditions_5.2.42.iso) = 49833984


Thatś it!
Comment 10 Ian Dickens 2020-05-21 19:27:15 UTC
(In reply to Mario Lobo from comment #9)

I did this on my poudriere build server by hand for one of my servers and it built find and is running fine so far.
Comment 11 Ian Dickens 2020-05-21 20:45:03 UTC
(In reply to Ian Dickens from comment #10)

Ok, I also changed the same Makefile and distinfo in virtualbox-ose-additions so that I could compile the additions-noX11 for my guests.  And seems to be going ok too.  Like I always do - I recompile virtualbox-ose-kmod on the hosts locally....
Comment 12 Mario Lobo 2020-05-21 20:49:48 UTC
Good to know! Thanks for the info. 

I had only tested the two main ports.
Comment 13 Jochen Neumeister freebsd_committer 2020-05-23 11:38:55 UTC
Approved for MFH after add a vuxml entry for the CVE's

ports-secteam (joneum)
Comment 14 Guido Falsi freebsd_committer 2020-06-28 14:07:42 UTC
Hi,

I've created a new review: https://reviews.freebsd.org/D25496

I've taken Mario Lobo patch here and cleaned it up a little.

Could I get it reviewed? Thanks!
Comment 15 VVD 2020-06-28 14:25:43 UTC
(In reply to Guido Falsi from comment #14)
python2.6???
Comment 16 Guido Falsi freebsd_committer 2020-06-28 14:41:04 UTC
(In reply to VVD from comment #15)

> python2.6???

Sorry I don't get the question, my patches use python.3.7.

I do patch upstream code that already mentions python 2.6 ad add the actual interpreter to the list.

I can change the patch to put the actual interpreter at the start of it, but since upstream code tests from older to newer I thought I'd leave the logic unchanged.
Comment 17 Guido Falsi freebsd_committer 2020-06-28 14:49:58 UTC
(In reply to Guido Falsi from comment #16)

The reason I'm patching Config.kmk in that part detecting python is that in poudriere builds no "python3" executable is installed by USES=python:3.7, but only the "python3.7" executable. So I need to add it to the list of binaries being tested before built.
Comment 18 VVD 2020-06-28 15:12:34 UTC
Why USES=python:3.7?
Why not USES=python?
Comment 19 Guido Falsi freebsd_committer 2020-06-28 15:14:24 UTC
(In reply to VVD from comment #18)

I can adapt the patch for that. But I don't see why supporting old python 2.7 which is going to be removed.
Comment 20 VVD 2020-06-28 15:24:24 UTC
(In reply to Guido Falsi from comment #19)
3.7 is the default.
USES=python:3.7+
or
USES=python:3.5+

But not USES=python:3.7
Comment 21 Guido Falsi freebsd_committer 2020-06-28 15:57:30 UTC
(In reply to Guido Falsi from comment #19)

Right, anyway I changed it to USES=python, simply. It works fine with all of the ones we have in the ports tree, and once python2 will be gone it will factor out.

So you were right and I have accepted your suggestion.

I updated the patch in the review.
Comment 22 Mario Lobo 2020-06-29 14:09:26 UTC
(In reply to Guido Falsi from comment #14)

Perfect, Guido!

Compilation and execution without the little glitches!

Thank you!!

I'm attempting to work with the 6.1.10 port.  

This is where we stand:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234878

If you have the time, we could use your help :D!
Comment 23 Guido Falsi freebsd_committer 2020-06-29 20:52:43 UTC
(In reply to Mario Lobo from comment #22)

I made a minor update to the review, I hope to get approval to commit it soon.

I'd like to have virtualbox 6, and am willing to test it, but I don't know how much I can help with crashes in such a complex software.

I'll give it a try as soon as I have time though.
Comment 24 Derek Schrock 2020-07-02 00:14:30 UTC
Pulled an old machine out of storage that had VT-x/AMD-V that I can use for dedicated testing new vbox5 and vbox6.

Applied the review's raw diff to head ports and I've tested the following:

- Building with additions ISO enabled
- virtualbox GUI via xrdp
- importing ova
- Creating Linux and FreeBSD 64 VMs.
- Installing additions via ISO on EL7.
- Installing emulators/virtualbox-ose-additions on FreeBSD 12.1 amd64 VM
- Addition's VBoxControl.
- www/phpvirtualbox
- VNC Remote Desktop with auto port selection

Everything looks good.