Bug 244228 - mail/fetchmail build with krb-1.18 failing
Summary: mail/fetchmail build with krb-1.18 failing
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Greg Lewis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-19 13:55 UTC by Konstantin Belousov
Modified: 2020-02-22 18:29 UTC (History)
2 users (show)

See Also:
chalpin: maintainer-feedback+


Attachments
Proposed patch (784 bytes, patch)
2020-02-22 18:14 UTC, Corey Halpin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Greg Lewis freebsd_committer 2020-02-22 17:56:38 UTC
FWIW, s/krb5_des_string_to_key/krb5_string_to_key/ gets things working for me

I also removed files/patch-configure since it just changes some instances to another function that doesn't exist.

I'm not clear on why configure checks for a function the source doesn't use though.  Just for library detection maybe?
Comment 2 Corey Halpin 2020-02-22 18:14:52 UTC
Created attachment 211840 [details]
Proposed patch

The attached patch updates the check in configure to look for a symbol that exists in all three versions of krb5 that currently exist in the ports tree.

The check is indeed for library detection, and worked correctly for krb5 < 1.18.
Comment 3 Corey Halpin 2020-02-22 18:19:25 UTC
For a bit of the history on the patch-configure, see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227680 and https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234740#c3
Comment 4 commit-hook freebsd_committer 2020-02-22 18:24:52 UTC
A commit references this bug:

Author: glewis
Date: Sat Feb 22 18:24:30 UTC 2020
New revision: 526846
URL: https://svnweb.freebsd.org/changeset/ports/526846

Log:
  Fix the build with the latest krb5 port

  PR:		244228
  Submitted by:	Corey Halpin <chalpin@cs.wisc.edu> (maintainer)

Changes:
  head/mail/fetchmail/files/patch-configure