Bug 244286 - [patch] security/openvpn: Add option to build with --enable-async-push
Summary: [patch] security/openvpn: Add option to build with --enable-async-push
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Matthias Andree
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-21 17:43 UTC by Renato Botelho
Modified: 2020-03-16 22:58 UTC (History)
1 user (show)

See Also:
mandree: maintainer-feedback+


Attachments
patch (1.95 KB, patch)
2020-02-21 17:43 UTC, Renato Botelho
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Renato Botelho freebsd_committer 2020-02-21 17:43:59 UTC
Created attachment 211804 [details]
patch

Added a new option ASYNC_PUSH, disabled by default, to build it with --enable-async-push.

When this option is enabled it fails to build due to lack of -linotify, so I added it to patch-configure and submitted a bug upstream:

https://community.openvpn.net/openvpn/ticket/1256#ticket
Comment 1 Matthias Andree freebsd_committer 2020-02-21 19:27:03 UTC
Why don't we just add LIBS+=-Wl,--as-needed -linotify?
Comment 2 Renato Botelho freebsd_committer 2020-02-21 19:41:58 UTC
(In reply to Matthias Andree from comment #1)
OK.  Let me try that and update patch
Comment 3 Matthias Andree freebsd_committer 2020-02-21 19:52:04 UTC
No need, I have it
Comment 4 commit-hook freebsd_committer 2020-02-21 20:16:16 UTC
A commit references this bug:

Author: mandree
Date: Fri Feb 21 20:15:50 UTC 2020
New revision: 526692
URL: https://svnweb.freebsd.org/changeset/ports/526692

Log:
  openvpn: Add default-off ASYNC_PUSH option.

  When enabled, pulls in devel/libinotify, and
  adds --enable-async-push to configure.

  In contrast to garga@'s proposal, uses
  ASYNC_PUSH_LIBS instead of a patch file.

  PR:		244286
  Submitted by:	garga@

Changes:
  head/security/openvpn/Makefile
Comment 5 Lev Stipakov 2020-03-16 07:47:34 UTC
Hi,

Please be aware that a fix for this issue has been committed to openvpn master branch: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg19566.html
Comment 6 Lev Stipakov 2020-03-16 08:12:35 UTC
Fixed also in release/2.4 https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg19568.html
Comment 7 Matthias Andree freebsd_committer 2020-03-16 22:36:22 UTC
OK, thanks for driving this with the upstream maintainers - we can possibly drop the ASYNC_PUSH_LIBS line after the next release from the upstream (which might be called 2.4.9).
Comment 8 commit-hook freebsd_committer 2020-03-16 22:58:59 UTC
A commit references this bug:

Author: mandree
Date: Mon Mar 16 22:58:27 UTC 2020
New revision: 528550
URL: https://svnweb.freebsd.org/changeset/ports/528550

Log:
  security/openvpn: Add a FIXME marker to clean up a local workaround that was upstreamed for 2.4.9. [info: Lev Stipakov]
  PR: 244286

Changes:
  head/security/openvpn/Makefile