Bug 244302 - WITHOUT_LZMA_SUPPORT has no effect
Summary: WITHOUT_LZMA_SUPPORT has no effect
Status: New
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Warner Losh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-22 08:35 UTC by Xin LI
Modified: 2020-02-22 08:39 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Xin LI freebsd_committer 2020-02-22 08:35:10 UTC
src.conf option WITHOUT_LZMA_SUPPORT has no effect.  The library and the xz utilities are always built.  There is no use of MK_LZMA_SUPPORT throught the whole base system.

I have added support for MK_LZMA_SUPPORT in gzip(1), and on amd64 -CURRENT, the version without LZMA support is only 8KiB smaller than the version with it.  The shared object itself is about 180KiB.

I think if the goal is to support it, we should teach build system about it (e.g. don't build LZMA libraries, etc.), but personally I don't see much point of doing this so perhaps we should just remove this option.
Comment 1 Xin LI freebsd_committer 2020-02-22 08:39:10 UTC
-> imp@ for triage.

The option was added in r263997 and the sole user was grep.  Compression support was removed in r332995 by bapt@.