Bug 244314 - devel/py-pygit2: fix RUN_DEPENDS definition
Summary: devel/py-pygit2: fix RUN_DEPENDS definition
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Matthias Fechner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-22 16:12 UTC by John Hein
Modified: 2020-02-29 14:19 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (mfechner)


Attachments
[patch] don't define RUN_DEPENDS based on BUILD_DEPENDS (921 bytes, text/plain)
2020-02-22 16:12 UTC, John Hein
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2020-02-22 16:12:24 UTC
Created attachment 211837 [details]
[patch] don't define RUN_DEPENDS based on BUILD_DEPENDS

The porter's handbook advises that RUN_DEPENDS should be defined based on BUILD_DEPENDS.

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-depend.html#makefile-run_depends

portlint noticed the problem:

FATAL: Makefile: RUN_DEPENDS should not be set to ${BUILD_DEPENDS} as ${BUILD_DEPENDS} includes other implicit dependencies.  Instead, copy the explicit dependencies from BUILD_DEPENDS to RUN_DEPENDS.  See http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-depend.html#AEN2154 for more details.

It's probably okay to include this fix with a later change.  There is a chance that some change to Uses/python.mk causes additional BUILD_DEPENDS that would then propagate to RUN_DEPENDS, thus changing the package.  But the likelihood of such a change seems low.  So this change can wait to be included with another future change (e.g., PORTVERSION update).
Comment 1 John Hein 2020-02-22 16:14:02 UTC
(In reply to John Hein from comment #0)

Oops... s|should be defined|should not be defined|
Comment 2 commit-hook freebsd_committer 2020-02-29 14:18:58 UTC
A commit references this bug:

Author: mfechner
Date: Sat Feb 29 14:18:31 UTC 2020
New revision: 527420
URL: https://svnweb.freebsd.org/changeset/ports/527420

Log:
  Cosmetic change for the dependency definition.
  There is no change in the definition, so no port bump.
  This should prevent later problems if the BUILD_DEPENDS or RUN_DEPENDS is modified by USE definitions.

  PR:		244314
  Submitted by:	jcfyecrayz@liamekaens.com

Changes:
  head/devel/py-pygit2/Makefile
Comment 3 Matthias Fechner freebsd_committer 2020-02-29 14:19:49 UTC
Committed, thanks.