Bug 244345 - devel/ghidra: Install /usr/local/share/ghidra/support/launch.properties as a @sample file
Summary: devel/ghidra: Install /usr/local/share/ghidra/support/launch.properties as a ...
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mateusz Piotrowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-23 19:58 UTC by Mateusz Piotrowski
Modified: 2020-08-19 12:53 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (sghctoma)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mateusz Piotrowski freebsd_committer 2020-02-23 19:58:27 UTC
I was looking for a way to start Ghidra with a non-default JDK and found out that it is possible by overriding some defaults in the /usr/local/share/ghidra/support/launch.properties file.

Would it be possible to install this file as /usr/local/share/ghidra/support/launch.properties.sample and mark it with @sample in pkg-plist so that user modification are not overwritten by an package update?

More on the @sample keyword: https://www.freebsd.org/doc/en/books/porters-handbook/book.html#plist-keywords-sample
Comment 1 Tamas Szakaly 2020-02-26 07:42:00 UTC
Thank you, this seems like a good idea!
I've just realized I'm also behind with two minor versions (we have 9.1 and the most recent is 9.1.2), so I think I'll make this change with the updated version.
Comment 2 TommiP 2020-05-06 10:48:26 UTC
Hi Tamas,

do you need help testing the new version (9.1.2)?
[Don't want to open up a new bug just for a version update]
Comment 3 TommiP 2020-08-19 12:36:11 UTC
(In reply to Tamas Szakaly from comment #1)
Hi Tamas,

do you need help with testing the new version 9.1.2?

Br,

Tommi
Comment 4 Mateusz Piotrowski freebsd_committer 2020-08-19 12:53:37 UTC
(In reply to TommiP from comment #2)

It might be a good idea to open a new PR so that we could commit the update in case of a maintainer timeout.