Created attachment 211875 [details]
Fix undefined symbol problem in scfb video driver
Besides pulling in the patch from github, this also does some
minor cleanup to pacify portlint.
When loading scfb on xorg 1.20.7 it fails with an
undefined symbol error:
scfb trace: probe start
scfb trace: probe done
scfb: PreInit 0
scfb: PreInit done
scfb: ScfbScreenInit 0
bitsPerPixel=32, depth=24, defaultVisual=TrueColor
mask: ff0000,ff00,ff, offset: 16,8,0
mmap returns: addr 0x805a10000 len 0x640000, fd 12, off 0
scfb: ScfbSave 0
scfb: ScfbSave done
scfb: ScfbScreenInit done
ld-elf.so.1: /usr/local/lib/xorg/modules/drivers/scfb_drv.so: Undefined
Disabling ShadowFB makes the driver load, but breaks output.
With this fix, the driver loads and was reported to work
properly (at least for "normal" daily use).
The fix was inspired by a similar change in fbdev:
Fix tested on two machines, port build qa with poudriere testport
on amd64 and i386 still running.
A commit references this bug:
Date: Sun Feb 23 23:20:32 UTC 2020
New revision: 526947
Unbreak on xorg-server 1.20.7 (and minor cleanup)
Approved by: manu