Bug 244353 - x11-drivers/xf86-video-scfb: Unbreak on xorg-server 1.20.7 (and minor cleanup)
Summary: x11-drivers/xf86-video-scfb: Unbreak on xorg-server 1.20.7 (and minor cleanup)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Michael Gmelin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-23 22:36 UTC by Michael Gmelin
Modified: 2020-02-23 23:21 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (x11)


Attachments
Fix undefined symbol problem in scfb video driver (2.46 KB, text/plain)
2020-02-23 22:36 UTC, Michael Gmelin
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Gmelin freebsd_committer 2020-02-23 22:36:13 UTC
Created attachment 211875 [details]
Fix undefined symbol problem in scfb video driver

Besides pulling in the patch from github, this also does some
minor cleanup to pacify portlint.

See https://github.com/rayddteam/xf86-video-scfb/pull/4

When loading scfb on xorg 1.20.7 it fails with an
undefined symbol error:

scfb trace: probe start
scfb trace: probe done
scfb: PreInit 0
scfb: PreInit done
scfb: ScfbScreenInit 0
bitsPerPixel=32, depth=24, defaultVisual=TrueColor
mask: ff0000,ff00,ff, offset: 16,8,0
mmap returns: addr 0x805a10000 len 0x640000, fd 12, off 0
scfb: ScfbSave 0
scfb: ScfbSave done
scfb: ScfbScreenInit done
ld-elf.so.1: /usr/local/lib/xorg/modules/drivers/scfb_drv.so: Undefined
symbol "shadowUpdatePackedWeak"

Disabling ShadowFB makes the driver load, but breaks output.

With this fix, the driver loads and was reported to work
properly (at least for "normal" daily use).

The fix was inspired by a similar change in fbdev:
freedesktop/xf86-video-fbdev@2673e72

Fix tested on two machines, port build qa with poudriere testport
on amd64 and i386 still running.
Comment 1 Emmanuel Vadot freebsd_committer 2020-02-23 22:48:37 UTC
LGTM
Thanks.
Comment 2 commit-hook freebsd_committer 2020-02-23 23:21:09 UTC
A commit references this bug:

Author: grembo
Date: Sun Feb 23 23:20:32 UTC 2020
New revision: 526947
URL: https://svnweb.freebsd.org/changeset/ports/526947

Log:
  Unbreak on xorg-server 1.20.7 (and minor cleanup)

  PR:		244353
  Approved by:	manu

Changes:
  head/x11-drivers/xf86-video-scfb/Makefile
  head/x11-drivers/xf86-video-scfb/distinfo
  head/x11-drivers/xf86-video-scfb/pkg-descr
  head/x11-drivers/xf86-video-scfb/pkg-plist