Created attachment 211888 [details]
yadifa 2.9.3 additional options
I was notified that building on FreeBSD 13.0 alerted about having a single source URL.
That's solved with this patch.
But more severe changes to this port are additional OPTIONS,
allowing better customization - something I deem very important
(old work I never submitted, but now is a nice moment to do so).
Having PORTREVISION in there could be debatable;
it serves no need to reinstall current installs.
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/120470680
Can the new options (DDNS, LARGEFILE and MASTER) get enabled by default? As to not break backwards compatibility.
Maybe MESSAGE should also get enabled?
From configure: "Disable usage of message structure API (not recommended)"
Created attachment 211903 [details]
yadifa 2.9.3 + additional options + defaults
Enabling DDNS, LARGEFILE and MASTER seems to me in deed a better idea.
And the MESSAGE option has evolved it seems;
like this I think it's better to even remove it.
Another thing I noticed has changed was TCL - it was removed, so the option became pointless. So I remove that also.
New patch (tested) does all of the above.
Created attachment 211924 [details]
yadifa 2.9.3 + add. options + add. defaults, clearer configure
Same but more clear configure section
(done poudriere and portlint).
After some testing, MESSAGES support seems to breaks IPv6.
I reported it upstream: https://www.yadifa.eu/archives/yadifa-users/2020-February/000138.html
Created attachment 212020 [details]
yadifa 2.9.3 + add. options + add. defaults, clearer configure + plist OK
Good to know, thanks Colin.
When using my own patch, I discovered minor plist mistakes regarding DDNS files.
This one is correcting that.
Why did you stop using <option>_CONFGIGURE_ENABLE?
(In reply to Tobias C. Berner from comment #7)
Because of the defaults of the software's configure;
in some cases you really need to disable specificaly.
As I do not wish to keep track of the defaults, I've defined everything, while maybe half of them are strictly needed.
Of course I initially ended with:
But I think that:
gives a clearer overview / makes it easy to spot typo's.
And in number of lines it doesn't matter.