Bug 244362 - dns/yadifa: Add OPTIONS, Fix FreeBSD 13.x issues
Summary: dns/yadifa: Add OPTIONS, Fix FreeBSD 13.x issues
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs mailing list
URL: http://yadifa.eu/
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2020-02-24 10:18 UTC by Leo Vandewoestijne
Modified: 2020-03-11 14:41 UTC (History)
1 user (show)

See Also:


Attachments
yadifa 2.9.3 additional options (2.30 KB, text/plain)
2020-02-24 10:18 UTC, Leo Vandewoestijne
freebsd: maintainer-approval+
Details
yadifa 2.9.3 + additional options + defaults (2.62 KB, patch)
2020-02-24 18:01 UTC, Leo Vandewoestijne
freebsd: maintainer-approval+
Details | Diff
yadifa 2.9.3 + add. options + add. defaults, clearer configure (2.12 KB, text/plain)
2020-02-25 11:27 UTC, Leo Vandewoestijne
freebsd: maintainer-approval+
Details
yadifa 2.9.3 + add. options + add. defaults, clearer configure + plist OK (2.53 KB, patch)
2020-02-28 12:11 UTC, Leo Vandewoestijne
freebsd: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Vandewoestijne 2020-02-24 10:18:54 UTC
Created attachment 211888 [details]
yadifa 2.9.3 additional options

I was notified that building on FreeBSD 13.0 alerted about having a single source URL.
That's solved with this patch.

But more severe changes to this port are additional OPTIONS,
allowing better customization - something I deem very important
(old work I never submitted, but now is a nice moment to do so).

Having PORTREVISION in there could be debatable;
it serves no need to reinstall current installs.
Comment 1 Automation User 2020-02-24 10:37:32 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/120470680
Comment 2 Colin T. 2020-02-24 11:16:26 UTC
Can the new options (DDNS, LARGEFILE and MASTER) get enabled by default? As to not break backwards compatibility.

Maybe MESSAGE should also get enabled?
From configure: "Disable usage of message structure API (not recommended)"
Comment 3 Leo Vandewoestijne 2020-02-24 18:01:56 UTC
Created attachment 211903 [details]
yadifa 2.9.3 + additional options + defaults

Enabling DDNS, LARGEFILE and MASTER seems to me in deed a better idea.

And the MESSAGE option has evolved it seems;
like this I think it's better to even remove it.

Another thing I noticed has changed was TCL - it was removed, so the option became pointless. So I remove that also.

New patch (tested) does all of the above.
Comment 4 Leo Vandewoestijne 2020-02-25 11:27:19 UTC
Created attachment 211924 [details]
yadifa 2.9.3 + add. options + add. defaults, clearer configure

Same but more clear configure section
(done poudriere and portlint).
Comment 5 Colin T. 2020-02-28 08:24:29 UTC
After some testing, MESSAGES support seems to breaks IPv6.
I reported it upstream: https://www.yadifa.eu/archives/yadifa-users/2020-February/000138.html
Comment 6 Leo Vandewoestijne 2020-02-28 12:11:27 UTC
Created attachment 212020 [details]
yadifa 2.9.3 + add. options + add. defaults, clearer configure + plist OK

Good to know, thanks Colin.

When using my own patch, I discovered minor plist mistakes regarding DDNS files.
This one is correcting that.
Comment 7 Tobias C. Berner freebsd_committer 2020-03-08 16:15:53 UTC
Moin moin 

Why did you stop using <option>_CONFGIGURE_ENABLE?


mfg Tobias
Comment 8 Leo Vandewoestijne 2020-03-11 14:41:05 UTC
(In reply to Tobias C. Berner from comment #7)
Because of the defaults of the software's configure;
in some cases you really need to disable specificaly.

As I do not wish to keep track of the defaults, I've defined everything, while maybe half of them are strictly needed.

Of course I initially ended with:

BLA_CONFIGURE_ENABLE= bla
BLA_CONFIGURE_OFF=    --disable-bla

But I think that:

BLA_CONFIGURE_ON=     --enable-bla
BLA_CONFIGURE_OFF=    --disable-bla

gives a clearer overview / makes it easy to spot typo's.
And in number of lines it doesn't matter.