Bug 244366 - databases/sqlite3: Include json1 support by default
Summary: databases/sqlite3: Include json1 support by default
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Bernhard Froehlich
URL:
Keywords: needs-qa
Depends on:
Blocks: 244279
  Show dependency treegraph
 
Reported: 2020-02-24 13:13 UTC by Sascha Biberhofer
Modified: 2020-03-18 13:21 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (pavelivolkov)
koobs: merge-quarterly?


Attachments
databases/sqlite3: include json1 support by default (594 bytes, patch)
2020-03-05 13:11 UTC, Sascha Biberhofer
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sascha Biberhofer 2020-02-24 13:13:01 UTC
The most recent version of our net-im/py-matrix-synapse port requires json1 support for sqlite3. 

Can we include this in the default options for the sqlite3 port? Otherwise people relying on packages and using synapse w/ sqlite3 cannot upgrade past 1.11.0. I'm also open to other suggestions.
Comment 1 Sascha Biberhofer 2020-03-05 13:11:30 UTC
Created attachment 212156 [details]
databases/sqlite3: include json1 support by default

I've attached a trivial patch to enable JSON1 support by default for the databases/sqlite3 port. 

This...

- ... doesn't incur any additional dependencies
- ... resolves this bug and allows us to move forward with updating py-matrix-synapse
- ... seems like the most trivial solution for this current problem


Can we get this committed? There's a security critical update for py-matrix-synapse that is waiting for any action on this issue. I'm completely open for suggestions on how to resolve this differently, but I'd like to move on this rather quickly for obvious reasons.
Comment 2 Bernhard Froehlich freebsd_committer 2020-03-11 12:48:22 UTC
I've checked a few Linux distributions about the status of the json extension. At least the following have it enabled:

- Debian (buster)
- OpenSuse
- ArchLinux
- Alpine Linux

In the ArchLinux PKGBUILD [1] there is a comment "json extensions breaks parallel build" where I am not sure if that is still valid.

[1] https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/sqlite

Technically we already have a maintainer timeout but i'll prefer to wait a few more days to hopefully get some feedback from the maintainer.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2020-03-13 04:20:33 UTC
Since the matrix-synapse update in bug 244279  needs to be MFH's (security update), this will need to be merged too

Is more comprehensize QA (such as an exp-run) required or indicated given the number of consumers of sqlite?
Comment 4 Pavel Volkov 2020-03-18 13:21:38 UTC
Hello. I'm added this path to PR#243602. Please check it status.
(https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243602)