Bug 244373 - print/hplip: replace dependency from python 2.7 to default 3.7: pygobject => pygobject3
Summary: print/hplip: replace dependency from python 2.7 to default 3.7: pygobject => ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Ben Woods
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-24 16:29 UTC by VVD
Modified: 2020-02-24 23:47 UTC (History)
0 users

See Also:
woodsb02: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description VVD 2020-02-24 16:29:13 UTC
print/hplip/Makefile:
-USE_GNOME=      pygobject
+USE_GNOME=      pygobject3

Tested build on 12.1 amd64.
Comment 1 Ben Woods freebsd_committer 2020-02-24 22:49:53 UTC
Actually, as explained in the Porter's handbook section 6.11. GNOME Components, there are 3 options for pygobject:
py3gobject3	devel/py3-gobject3	Python 3, GObject 3.0 bindings
pygobject3	devel/py-gobject3	Python 2, GObject 3.0 bindings
pygobject	devel/py-gobject	Python 2, GObject 2.0 bindings

If the goal is to move to python3 (due to obsolescence of python2), then we need to change to py3gobject3.

We will also need to confirm print/hplip supports GObject 3.0 bindings.
Comment 2 Ben Woods freebsd_committer 2020-02-24 22:57:06 UTC
Apologies, it looks like the USE_GNOME=py3gobject3 option is no longer available, and the Porter's Handbook needs to be updated to reflect that change. I assume this change was part of introducing flavors support for python.

Indeed USE_GNOME=pygobject3 is sufficient.
Comment 3 commit-hook freebsd_committer 2020-02-24 23:07:09 UTC
A commit references this bug:

Author: woodsb02
Date: Mon Feb 24 23:06:36 UTC 2020
New revision: 527054
URL: https://svnweb.freebsd.org/changeset/ports/527054

Log:
  print/hplip: Change USE_GNOME dependency from pygobject to pygobject3

  PR:		244373
  Submitted by:	vvd@unislabs.com

Changes:
  head/print/hplip/Makefile
Comment 4 Ben Woods freebsd_committer 2020-02-24 23:07:43 UTC
Committed - thanks VVD!
Comment 5 VVD 2020-02-24 23:43:45 UTC
(In reply to Ben Woods from comment #4)
PORTREVISION up?
Comment 6 commit-hook freebsd_committer 2020-02-24 23:47:13 UTC
A commit references this bug:

Author: woodsb02
Date: Mon Feb 24 23:46:25 UTC 2020
New revision: 527055
URL: https://svnweb.freebsd.org/changeset/ports/527055

Log:
  print/hplip: Bump PORTREVISION post r527054

  PR:		244373
  Reported by:	vvd@unislabs.com

Changes:
  head/print/hplip/Makefile