Created attachment 211901 [details] Patch against /usr/ports/www/tomcat85 Tomcat comes with resource bundles for various languages. Those are used in responses and logs. Sometimes, it is not desired to have them. The attached patch adds NLS support omitting them from the installation. Same patch can be providef for 9.0 too.
Do we need some ${RM} in Makefile? Something like this in post-patch section: @${RM} ${WRKSRC}/lib/tomcat-i18n-*.jar
(In reply to VVD from comment #1) No, I ran it through Poudriere and received no errors/warning. The best thing is that %%NLS%% is replaced with @comment if disabled. So no file will be stale or missing from pkg-plist.
Ok. Attach same patch for 9.0 too, plz. :-]
Created attachment 211931 [details] Patch against /usr/ports/www/tomcat9 Here it is. Runs fine in Poudriere.
Comment on attachment 211931 [details] Patch against /usr/ports/www/tomcat9 OK. Look fine for me.
(In reply to VVD from comment #5) How to set maintainer-approval on file? Tried, but no result…
(In reply to VVD from comment #6) I see a plus here. Looks fine to me. One might want to bump port revision again.
Take it
A commit references this bug: Author: fluffy Date: Sat Feb 29 16:48:47 UTC 2020 New revision: 527443 URL: https://svnweb.freebsd.org/changeset/ports/527443 Log: www/tomcat[8|95]: add NLS option, OFF by default Tomcat comes with resource bundles for various languages. Those are used in responses and logs. Sometimes, it is not desired to have them. Add NLS option support omitting them from the installation. Bump PORTREVISION PR: 244374 Submitted by: Michael Osipov Approved by: maintainer Changes: head/www/tomcat85/Makefile head/www/tomcat85/pkg-plist head/www/tomcat9/Makefile head/www/tomcat9/pkg-plist
Committed, thanks!