Created attachment 212215 [details] Patch for net/py-raet - Update USES=python to include python3 net/py-raet: Update USES=python to include python3 Python3 support was added in raet version 0.5.0: https://github.com/RaetProtocol/raet/blob/master/ChangeLog.md#20150204-2
Hi Christer / Koobs, Can I please get your thoughts on this change? I can't find anything more specific about exact python3 versions supported. Regards, Ben
(In reply to Ben Woods from comment #1) FWIW if you mean ports, and have a ports tree handy. All that magic is located in Mk/Uses eg; Mk/Uses/python.mk So USES= python3+ will provide support (currently) for versions 3.5 - 3.8 HTH --Chris
(In reply to Chris Hutchinson from comment #2) Hi Chris, The issue is that this port previously claimed to only support python 2.7, but actually the upstream code also supports python3. Hence the value of USES=python needs to be updated in this port to reflect upstream, as per the attached patch. I can't find any more specific details upstream about which exact versions of python3 are supported (e.g. does their code work with python 3.6, 3.7 and 3.8?)
(In reply to Ben Woods from comment #3) At least Python 3.5 [1] The key here is going to be getting the tests running for the port (test_depends / test target) and reaching out to upstream to confirm. [1] https://github.com/RaetProtocol/raet/commit/19391b599cdde2399889522c442f6bd779525ce3
Comment on attachment 212215 [details] Patch for net/py-raet - Update USES=python to include python3 Approved by: portmgr (blanket: dependency fix, ports (python) compliance) MFH: 2020Q1
Make that at least 3.6 [1] https://github.com/RaetProtocol/raet/commit/16a05b81daaaa8ec7933719e312b5f0274ee3ade
I have reached out to upstream by submitting an issue on their GitHub: https://github.com/RaetProtocol/raet/issues/12
A commit references this bug: Author: woodsb02 Date: Sun Mar 8 23:16:22 UTC 2020 New revision: 528084 URL: https://svnweb.freebsd.org/changeset/ports/528084 Log: net/py-raet: Update USES=python to include python3 Python3 support was added in raet version 0.5.0: https://github.com/RaetProtocol/raet/blob/master/ChangeLog.md#20150204-2 Exactly which python 3 versions are supported / known to work will be discussed here: https://github.com/RaetProtocol/raet/issues/12 We know at least python 3.5 and 3.6 are supported: https://github.com/RaetProtocol/raet/commit/19391b599cdde2399889522c442f6bd779525ce3 https://github.com/RaetProtocol/raet/commit/16a05b81daaaa8ec7933719e312b5f0274ee3ade PR: 244653, 243610 Submitted by: Tommy P <tommyhp2@gmail.com> Approved by: portmgr (blanket: dependency fix, ports (python) compliance) MFH: 2020Q1 Changes: head/net/py-raet/Makefile
Committed to head. I might wait a few days before MFH to see if we get any response from upstream first.
(In reply to commit-hook from comment #8) Thanks Ben!
Committed, and MFH not necessary since 2020Q2 ports quarterly branch now exists - thanks for your input koobs.