Bug 244741 - ports-mgmt/portlint: Do not warn about ${DISTNAME}${EXTRACT_SFX} in DISTFILES if USE_GITHUB=nodefault
Summary: ports-mgmt/portlint: Do not warn about ${DISTNAME}${EXTRACT_SFX} in DISTFILES...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joe Marcus Clarke
URL:
Keywords: buildisok, patch
Depends on:
Blocks:
 
Reported: 2020-03-11 17:33 UTC by Mateusz Piotrowski
Modified: 2020-05-30 13:55 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (marcus)

Attachments
Patch (2.63 KB, patch)
2020-03-11 17:33 UTC, Mateusz Piotrowski 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mateusz Piotrowski freebsd_committer freebsd_triage 2020-03-11 17:33:01 UTC 
Created attachment 212338 [details]
Patch

Setting DISTFILES to ${DISTNAME}${EXTRACT_SFX} is the recommended way of mixing USE_GITHUB=nodefault with MASTER_SITES.

https://www.freebsd.org/doc/en/books/porters-handbook/book.html#makefile-distfiles (See 5.4.3.1)
Comment 1 Automation User 2020-03-26 03:26:43 UTC 
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/129793212
Comment 2 Joe Marcus Clarke freebsd_committer freebsd_triage 2020-05-30 13:24:30 UTC 
Committed to my repo pending the next release.
Comment 3 Joe Marcus Clarke freebsd_committer freebsd_triage 2020-05-30 13:55:51 UTC 
Committed to 2.19.0.  Thanks!