Bug 244777 - emulators/qemu-user-static-devel: Fix build with lld 10.0.0
Summary: emulators/qemu-user-static-devel: Fix build with lld 10.0.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-emulation (Nobody)
URL:
Keywords:
Depends on:
Blocks: 244251
  Show dependency treegraph
 
Reported: 2020-03-12 21:24 UTC by Dimitry Andric
Modified: 2020-03-20 13:17 UTC (History)
1 user (show)

See Also:
kevans: maintainer-feedback+


Attachments
Fix emulators/qemu-user-static-devel build with lld 10.0.0 (3.29 KB, patch)
2020-03-12 21:24 UTC, Dimitry Andric
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2020-03-12 21:24:38 UTC
Created attachment 212366 [details]
Fix emulators/qemu-user-static-devel build with lld 10.0.0

As reported in bug 244251, with clang and lld 10.0.0 the emulators/qemu-user-static-devel port fails in the configure stage:

===>  Configuring for qemu-user-static-devel-3.1.0_3

ERROR: We need to link the QEMU user mode binaries at a
       specific text address. Unfortunately your linker
       doesn't support either the -Ttext-segment option or
       printing the default linker script with --verbose.
       If you don't want the user mode binaries, pass the
       --disable-user option to configure.

===>  Script "configure" failed unexpectedly.
Please report the problem to emulation@FreeBSD.org [maintainer] and attach
the
"/wrkdirs/usr/ports/emulators/qemu-user-static-devel/work/qemu-bsd-user-e21442a/config.log"
including the output of the failure of your make command. Also, it might be
a good idea to provide an overview of all packages installed on your system
(e.g. a /usr/local/sbin/pkg-static info -g -Ea).
*** Error code 1

This is because lld 10.0.0 no longer supports the -Ttext-segment option, and uses --image-base for similar functionality.

I am proposing a patch that makes the configure script check for the --image-base option first, then the -Ttext-segment option.
Comment 1 Kyle Evans freebsd_committer freebsd_triage 2020-03-19 18:09:11 UTC
Maintainer approves.
Comment 2 Kyle Evans freebsd_committer freebsd_triage 2020-03-20 13:17:37 UTC
Committed as r528752; too many qemu ports and the messages got a bit cross-threaded. =-)