Bug 244794 - www/py-flask-wtf: Update to 0.14.3
Summary: www/py-flask-wtf: Update to 0.14.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Ruslan Makhmatkhanov
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2020-03-13 16:07 UTC by Goran Mekić
Modified: 2020-03-17 01:32 UTC (History)
1 user (show)

See Also:
koobs: maintainer-feedback+

Attachments
py-flask-wtf.diff (1.55 KB, patch)
2020-03-13 16:07 UTC, Goran Mekić 		no flags Details | Diff
py-flask-wtf.diff (1.52 KB, patch)
2020-03-14 10:22 UTC, Goran Mekić 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Goran Mekić 2020-03-13 16:07:46 UTC 
Created attachment 212386 [details]
py-flask-wtf.diff

QA:

  * portlint: OK (looks fine.)
  * testport: OK (poudriere: 12.1, amd64 tested)

Old versions are broken. Breakage is caused by new werkzeug version.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2020-03-14 00:34:52 UTC 
Thanks Goran. Could you please:

- Delete TESTS / TESTS_DESC option and TESTS_BUILD_DEPENDS (this is now handled by the framework)

- Check that this ports werkzeug <version-spec> is correctly defined, matching the upstream (setup.py) version-spec,  updating it if necessary, so that issues like this can be picked up earlier when updating its dependents

- If the werkzeug update regressing this port was merged to quarterly (and flask-wtf is broken there now too), set merge-quarterly > here
Comment 2 Goran Mekić 2020-03-14 10:06:08 UTC 
(In reply to Kubilay Kocak from comment #1)
I'm not sure it's wise to have werkzeug as dependency, as flask is depending on it, and flask-wtf depends on flask. What should I do?
Comment 3 Goran Mekić 2020-03-14 10:09:17 UTC 
I checked quarterly, werkzeug there is older: 0.16.0, so it's fine
Comment 4 Goran Mekić 2020-03-14 10:22:33 UTC 
Created attachment 212403 [details]
py-flask-wtf.diff
Comment 5 commit-hook freebsd_committer freebsd_triage 2020-03-16 18:27:43 UTC 
A commit references this bug:

Author: rm
Date: Mon Mar 16 18:26:44 UTC 2020
New revision: 528535
URL: https://svnweb.freebsd.org/changeset/ports/528535

Log:
  www/py-flask-wtf: update to 0.14.3

  This release fixes runtime with werkzeug 1.0.0

  PR:		244794
  Submitted by:	Goran Meki? <meka@tilda.center>
  Reviewed by:	koobs

Changes:
  head/www/py-flask-wtf/Makefile
  head/www/py-flask-wtf/distinfo
Comment 6 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2020-03-16 18:28:19 UTC 
Committed, thank you!