Bug 244797 - textproc/jtc: Unbreak build with clang 10.0.0, use correct PORTVERSION
Summary: textproc/jtc: Unbreak build with clang 10.0.0, use correct PORTVERSION
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-03-13 21:28 UTC by Lewis Cook
Modified: 2020-03-18 07:03 UTC (History)
1 user (show)

See Also:
fernape: maintainer-feedback+


Attachments
jtc-1.75d.diff (1.52 KB, patch)
2020-03-13 21:28 UTC, Lewis Cook
lcook: maintainer-approval+
Details | Diff
jtc-1.75d.log (13.19 KB, text/plain)
2020-03-13 21:29 UTC, Lewis Cook
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lewis Cook freebsd_committer freebsd_triage 2020-03-13 21:28:41 UTC
Created attachment 212389 [details]
jtc-1.75d.diff

Changes:
	* Replace 'DISTVERSION' with 'PORTVERSION', as the version
          contains letters and would output '1.75.d' — which is
          incorrect. In this instance there's no need to bump the
          'PORTREVISION' as '1.75d' > '1.75.d';
	* Add 'files/patch-lib_Json.hpp' which removes an incorrect
          function (we try modify a non-static member within a const
          function) and therefore unbreaking builds with clang 10.0.0.
          This has no behavioral change on the application itself. [1]

Testing:
	* No errors reported with portlint, built in Poudriere and
	  application works as expected (logs attached).

Notes:
	* [1] Reported by pkg-fallout @ http://beefy17.nyi.freebsd.org/data/head-i386-default/p528258_s358902/logs/jtc-1.75.d.log
Comment 1 Lewis Cook freebsd_committer freebsd_triage 2020-03-13 21:29:31 UTC
Created attachment 212391 [details]
jtc-1.75d.log

* Poudriere build log.
Comment 2 commit-hook freebsd_committer 2020-03-18 07:02:29 UTC
A commit references this bug:

Author: fernape
Date: Wed Mar 18 07:02:15 UTC 2020
New revision: 528627
URL: https://svnweb.freebsd.org/changeset/ports/528627

Log:
  textproc/jtc: unbreak with clang 10.0.0

  Additionally, use PORTVERSION instead of DISTVERSION

  PR:	244797
  Submitted by:	vulcan@wired.sh (maintainer)

Changes:
  head/textproc/jtc/Makefile
  head/textproc/jtc/files/
  head/textproc/jtc/files/patch-lib_Json.hpp
Comment 3 Fernando Apesteguía freebsd_committer 2020-03-18 07:03:06 UTC
Committed,

Thanks!